FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move future files out of internal/. by coryan · Pull Request #1450 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

Move future files out of internal/. #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryan merged 1 commit into from
Nov 15, 2018
Conversation 2 Commits 1 Checks 0 Files changed
Merged

Move future files out of internal/. #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .bzl  (2) .cc  (4) .h  (3) .txt  (1) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
12 changes: 6 additions & 6 deletions google/cloud/CMakeLists.txt
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ configure_file(internal/build_info.cc.in internal/build_info.cc)
# the client library
add_library(google_cloud_cpp_common
future.h
future_generic.h
future_void.h
iam_binding.h
iam_bindings.h
iam_bindings.cc
Expand All @@ -111,8 +113,6 @@ add_library(google_cloud_cpp_common
internal/future_impl.cc
internal/future_then_impl.h
internal/future_then_meta.h
internal/future_generic.h
internal/future_void.h
internal/getenv.h
internal/getenv.cc
internal/make_unique.h
Expand Down Expand Up @@ -171,15 +171,15 @@ target_link_libraries(google_cloud_cpp_testing
create_bazel_config(google_cloud_cpp_testing)

set(google_cloud_cpp_common_unit_tests
future_generic_test.cc
future_generic_then_test.cc
future_void_test.cc
future_void_then_test.cc
iam_bindings_test.cc
internal/backoff_policy_test.cc
internal/big_endian_test.cc
internal/filesystem_test.cc
internal/future_impl_test.cc
internal/future_generic_test.cc
internal/future_generic_then_test.cc
internal/future_void_test.cc
internal/future_void_then_test.cc
internal/invoke_result_test.cc
internal/random_test.cc
internal/retry_policy_test.cc
Expand Down
8 changes: 4 additions & 4 deletions google/cloud/internal/future_generic.h → google/cloud/future_generic.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_GENERIC_H_
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_GENERIC_H_
#ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_GENERIC_H_
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_GENERIC_H_
/**
* @file
*
Expand Down Expand Up @@ -49,7 +49,7 @@ class future final : private internal::future_base<T> {
* code is `std::future_errc::broken_promise`.
*
* @note The technical specification requires this to be a `noexcept`
* constructor I (@coryan) believe this is a defect in the technical
* constructor I (coryan) believe this is a defect in the technical
* specification, as this *creates* a new shared state: shared states are
* dynamically allocated, and the allocator (which might be the default
* `operator new`) may raise.
Expand Down Expand Up @@ -200,4 +200,4 @@ class promise final : private internal::promise_base<T> {
} // namespace cloud
} // namespace google

#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_GENERIC_H_
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_GENERIC_H_
2 changes: 1 addition & 1 deletion google/cloud/internal/future_generic_test.cc → google/cloud/future_generic_test.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "google/cloud/internal/future_generic.h"
#include "google/cloud/future_generic.h"
#include "google/cloud/testing_util/chrono_literals.h"
#include "google/cloud/testing_util/expect_future_error.h"
#include <gmock/gmock.h>
Expand Down
0 ...loud/internal/future_generic_then_test.cc → google/cloud/future_generic_then_test.cc
Show comments
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions google/cloud/internal/future_void.h → google/cloud/future_void.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_VOID_H_
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_VOID_H_
#ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_VOID_H_
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_VOID_H_
/**
* @file
*
Expand Down Expand Up @@ -49,7 +49,7 @@ class future<void> final : private internal::future_base<void> {
* code is `std::future_errc::broken_promise`.
*
* @note The technical specification requires this to be a `noexcept`
* constructor I (@coryan) believe this is a defect in the technical
* constructor I (coryan) believe this is a defect in the technical
* specification, as this *creates* a new shared state: shared states are
* dynamically allocated, and the allocator (which might be the default
* `operator new`) may raise.
Expand Down Expand Up @@ -186,4 +186,4 @@ class promise<void> final : private internal::promise_base<void> {
} // namespace cloud
} // namespace google

#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_FUTURE_VOID_H_
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_FUTURE_VOID_H_
2 changes: 1 addition & 1 deletion google/cloud/internal/future_void_test.cc → google/cloud/future_void_test.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "google/cloud/internal/future_void.h"
#include "google/cloud/future_void.h"
#include "google/cloud/testing_util/chrono_literals.h"
#include "google/cloud/testing_util/expect_future_error.h"
#include <gmock/gmock.h>
Expand Down
0 ...e/cloud/internal/future_void_then_test.cc → google/cloud/future_void_then_test.cc
Show comments
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions google/cloud/google_cloud_cpp_common.bzl
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# DO NOT EDIT -- GENERATED BY CMake -- Change the CMakeLists.txt file if needed
google_cloud_cpp_common_HDRS = [
"future.h",
"future_generic.h",
"future_void.h",
"iam_binding.h",
"iam_bindings.h",
"iam_policy.h",
Expand All @@ -13,8 +15,6 @@ google_cloud_cpp_common_HDRS = [
"internal/future_impl.h",
"internal/future_then_impl.h",
"internal/future_then_meta.h",
"internal/future_generic.h",
"internal/future_void.h",
"internal/getenv.h",
"internal/make_unique.h",
"internal/port_platform.h",
Expand Down
8 changes: 4 additions & 4 deletions google/cloud/google_cloud_cpp_common_unit_tests.bzl
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# DO NOT EDIT -- GENERATED BY CMake -- Change the CMakeLists.txt file if needed
google_cloud_cpp_common_unit_tests = [
"future_generic_test.cc",
"future_generic_then_test.cc",
"future_void_test.cc",
"future_void_then_test.cc",
"iam_bindings_test.cc",
"internal/backoff_policy_test.cc",
"internal/big_endian_test.cc",
"internal/filesystem_test.cc",
"internal/future_impl_test.cc",
"internal/future_generic_test.cc",
"internal/future_generic_then_test.cc",
"internal/future_void_test.cc",
"internal/future_void_then_test.cc",
"internal/invoke_result_test.cc",
"internal/random_test.cc",
"internal/retry_policy_test.cc",
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/internal/future_then_impl.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
* functions inline.
*/

#include "google/cloud/internal/future_generic.h"
#include "google/cloud/internal/future_void.h"
#include "google/cloud/future_generic.h"
#include "google/cloud/future_void.h"

namespace google {
namespace cloud {
Expand Down
Back | FazBrowse Home | New Git URL