Provide a way to unset blob metadata by mziccard · Pull Request #279 · googleapis/google-cloud-java · GitHub

This PR follows from #60 and provides a different solution from #276.
If blobInfo metadata are set to null then Data.nullOf(ImmutableEmptyMap.class) is used. This way patch is capable of unsetting the metadata if need be.

This PR also documents patch behavior in Blob and Storage javadocs, code snippets are added to show how to unset blob's metadata.

We could consider moving ImmutableEmptyMap out of BlobInfo, thoughts?

Good job, I like it and I think we should go with this option for fixing #60.

@mziccard What do you think?

@aozarov I agree, this is much cleaner than #276 and provides a reasonable way of circumventing #60. I'll take care of addressing all your comments.

- Use HashMap instead of ImmutableMap in builder.metadata - Use Collections.unmodifiableMap in blobInfo.metadata getter - Convert null values in metadata to Data.nullOf in blobInfo.toPb - Add integration tests - Add javadoc to mark BlobInfo.ImmutableEmptyMap as internal

Provide a way to unset blob metadata

Committer: @miraleung PiperOrigin-RevId: 378266372 Source-Link: googleapis/googleapis@9e31055 Source-Link: https://github.com/googleapis/googleapis-gen/commit/14629f6b39dfee67009f79a96d2077d5bb17d1c3

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.0 (#279) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-project-info-reports-plugin)) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-api-gateway).

🤖 I have created a release *beep* *boop* --- ## [1.2.3](googleapis/java-networkconnectivity@v1.2.2...v1.2.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#278](googleapis/java-networkconnectivity#278)) ([c9d00a8](googleapis/java-networkconnectivity@c9d00a8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jeepney](https://gitlab.com/takluyver/jeepney) | `==0.7.1` -> `==0.8.0` | [![age](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/compatibility-slim/0.7.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jeepney/0.8.0/confidence-slim/0.7.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dms).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-gsuite-addons/compare/v2.3.5...v2.3.6) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([14efe7d](https://togithub.com/googleapis/java-gsuite-addons/commit/14efe7d1ff861d4be6a79fa81549a188104b452d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* Add Signer for impersonatied credentials * add lint fixes * back to the future * Update oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java Co-Authored-By: Jeff Ching <chingor@google.com>

…eapis#279) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/407a758f-25d9-475d-8ed1-b8b2eb5d7c99/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@68742c6

…0.122.0 (#279)

Since we have several deprecated method in the ITPubSubTest, I think we can begin to migrate it to non-deprecated method one.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.api.grpc:grpc-google-common-protos](https://togithub.com/googleapis/java-iam) | minor | `1.17.0` -> `1.18.0` | | [com.google.api.grpc:proto-google-common-protos](https://togithub.com/googleapis/java-iam) | minor | `1.17.0` -> `1.18.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-bigtable).

Add null value (empty map) for blob metadata

333a3bb

mziccard added the api: storage Issues related to the Cloud Storage API. label Oct 22, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2015

mziccard added 3 commits October 22, 2015 15:06

Document patch behaviour in Blob and Storage javadoc

3b91741

Add integration test for replacing metadata

99178a3

Minor refactoring of ITStorageTest

04cf0a7

mziccard force-pushed the fix-unset-metadata branch from 380c5cc to 04cf0a7 Compare October 22, 2015 13:06

aozarov reviewed Oct 22, 2015
View reviewed changes

Comment thread gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobInfo.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

mziccard added 2 commits October 23, 2015 13:46

Use newHashMapWithExpectedSize instead of new HashMap

682848a

aozarov added a commit that referenced this pull request Oct 23, 2015

Merge pull request #279 from mziccard/fix-unset-metadata

33e932e

Provide a way to unset blob metadata

aozarov merged commit 33e932e into googleapis:master Oct 23, 2015

aozarov mentioned this pull request Oct 23, 2015

The result of a patch metadata is a union rather than replacement. #60

Closed

github-actions Bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#279 )

1a1bb5f

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore(deps): update dependency com.google.cloud:google-cloud-nio to v…

14353c2

…0.122.0 (#279)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore(deps): update dependency com.google.cloud:google-cloud-nio to v…

d3a62f4

…0.122.0 (#279)

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

test: Replace deprecated method with non-deprecated one (#279 )

754b14c

Since we have several deprecated method in the ITPubSubTest, I think we can begin to migrate it to non-deprecated method one.

meltsufin pushed a commit that referenced this pull request May 1, 2026

test: Replace deprecated method with non-deprecated one (#279 )

9719a07

Since we have several deprecated method in the ITPubSubTest, I think we can begin to migrate it to non-deprecated method one.

Provide a way to unset blob metadata by mziccard · Pull Request #279 · googleapis/google-cloud-java · GitHub

Uh oh!

Provide a way to unset blob metadata - #279

Provide a way to unset blob metadata#279
aozarov merged 6 commits into
googleapis:masterfrom
mziccard:fix-unset-metadata

mziccard commented Oct 22, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Oct 22, 2015

Uh oh!

mziccard commented Oct 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Provide a way to unset blob metadata by mziccard · Pull Request #279 · googleapis/google-cloud-java · GitHub

Uh oh!

Provide a way to unset blob metadata - #279

Provide a way to unset blob metadata#279aozarov merged 6 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:fix-unset-metadatamziccard/gcloud-java:fix-unset-metadataCopy head branch name to clipboard

Conversation

mziccard commented Oct 22, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Oct 22, 2015

Uh oh!

mziccard commented Oct 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Provide a way to unset blob metadata#279
aozarov merged 6 commits into
googleapis:masterfrom
mziccard:fix-unset-metadata