Make Project a subclass of ProjectInfo by ajkannan · Pull Request #572 · googleapis/google-cloud-java · GitHub

This is an alternate proof of concept for #530. This PR introduces the following changes:

Project is now a subclass of ProjectInfo.
- ResourceManager methods accept ProjectInfo objects but always return a Project
A new abstract builder class is added to ProjectInfo. Both ProjectInfo.BuilderImpl and Project.Builder extend this abstract Builder.
- The methods of Project.Builder delegate to ProjectInfo.BuilderImpl to avoid setter code duplication.
- The abstract class is for code maintenance. If there is a new field for projects, adding it to the abstract class will ensure that we add it to both ProjectInfo.BuilderImpl and Project.Builder.

A user can create a ProjectInfo (without supplying a service object) when creating or updating a project. Since Resource Manager methods will return Project objects instead of ProjectInfo objects, the user doesn't have to supply the service object any additional times for the typical use case.

/cc @mziccard @mderka @aozarov

Thoughts?

I like it! 👍

I need a bit more time to go through this. I follow up on Monday.

I added a few nit comments. Great job @ajkannan I think this makes the API more usable without being verbose and keeps the code clean and maintainable. 👍

Btw, I can implement this in either bigquery or storage or both, just let me know!

Looking a bit more into this. In bigquery we have a more complex situation where Info classes are part of a hierarchy.
For instance consider the TableInfo hierarchy where the BaseTableInfo class is extended by TableInfo, ViewInfo and ExternalTableInfo. Do you guys think this solution would still fit to the bigquery case?

@mziccard I'll take Storage and Resource Manager, and if you can take BigQuery, that'd be great.

I'll remove the "don't merge" label on this PR after I add changes to docs, fix the tests, and address the comments above.

Incorporated comments thus far and also updated README, javadoc, and tests. Ready for another pass.

Fixed more documentation issues and added a commit that adds a replace method with no arguments. This replace is useful because a common use case for replace is to use toBuilder on a project, which up until now required repetition. An example of the change would be:

myProject.toBuilder().addLabel("k", "v").build().replace();

rather than

myProject.replace(myProject.toBuilder().addLabel("k", "v").build())

Thoughts @mziccard @mderka?

@ajkannan empty replace method looks good to me!

Added a commit to remove the original replace method.

LGTM, please fix the doc issues we discussed before merge.

Fixed docs and re-tested sample in the docs.

Make Project a subclass of ProjectInfo

Source-Link: googleapis/synthtool@1a2878d Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:12cbdc4f137152a1a8b83f50ebc1a4098be0d3baff78b46efaec306f7cfafd13 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: Fix recommendationengine resource name configuration PiperOrigin-RevId: 473779245 Source-Link: googleapis/googleapis@ee05df9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/d151c136b7de66b7b524817360c639d011ef003d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDE1MWMxMzZiN2RlNjZiN2I1MjQ4MTczNjBjNjM5ZDAxMWVmMDAzZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…cp/templates/java_library/.kokoro (#1732) (#572) build(deps): bump certifi Bumps [certifi](https://togithub.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://togithub.com/certifi/python-certifi/releases) - [Commits](https://togithub.com/certifi/python-certifi/compare/2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/ae0d43e5f17972981fe501ecf5a5d20055128bea Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9de537d592b60e5eac73b374a28263969bae91ecdb29b445e894576fbf54851c

…to v2.3.2 (#572)

* feat: add self signed jwt support * update * chore: add more tests * update * update defaultscopes * update default scopes * update * update ComputeEngineCredentials * improve test coverage * update Co-authored-by: Brent Shaffer <betterbrent@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [0.25.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.24.1...v0.25.0) (2021-03-16) ### Features * add self signed jwt support ([#572](https://www.github.com/googleapis/google-auth-library-java/issues/572)) ([efe103a](https://www.github.com/googleapis/google-auth-library-java/commit/efe103a2e688ca915ec9925a72c49bb2a1b3c3b5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…to v2.3.2 (googleapis#572)

* feat: add self signed jwt support * update * chore: add more tests * update * update defaultscopes * update default scopes * update * update ComputeEngineCredentials * improve test coverage * update Co-authored-by: Brent Shaffer <betterbrent@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [0.25.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.24.1...v0.25.0) (2021-03-16) ### Features * add self signed jwt support ([#572](https://www.github.com/googleapis/google-auth-library-java/issues/572)) ([3732a22](https://www.github.com/googleapis/google-auth-library-java/commit/3732a2262cf1c100bf10178d96106ac2dabf4ce9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…jdbc to v2.3.5 (googleapis#572)

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-05-26 21:01:41,470 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-storage-nio/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-05-26 21:01:42,762 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/eef1a82c-3f5f-48e2-b16d-0c9afdadf0a6/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2020-12-15 22:39:13,531 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigtable/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2020-12-15 22:39:14,445 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/3f9ae92e-7ec9-4da2-95e0-49a01f5d0c1e/targets - [ ] To automatically regenerate this PR, check this box.

ajkannan added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: cloudresourcemanager Issues related to the Resource Manager API. labels Jan 22, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2016

ajkannan force-pushed the project-extends-projectinfo branch from 21794d1 to 5a7e887 Compare January 23, 2016 00:01

mziccard reviewed Jan 25, 2016
View reviewed changes

Comment thread gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/Project.java

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ajkannan mentioned this pull request Jan 25, 2016

Combine info and functional objects #561

Closed

ajkannan removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 27, 2016

ajkannan force-pushed the project-extends-projectinfo branch 2 times, most recently from 34fe23c to 951be77 Compare January 29, 2016 17:58

Make Project a subclass of ProjectInfo

a76e6c4

ajkannan force-pushed the project-extends-projectinfo branch from 951be77 to a76e6c4 Compare January 30, 2016 00:18

ajkannan added a commit that referenced this pull request Jan 30, 2016

Merge pull request #572 from ajkannan/project-extends-projectinfo

d3abf25

Make Project a subclass of ProjectInfo

ajkannan merged commit d3abf25 into googleapis:master Jan 30, 2016

ajkannan deleted the project-extends-projectinfo branch January 30, 2016 00:45

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

chore(deps): update dependency com.google.cloud:google-cloud-logging …

4f47df2

…to v2.3.2 (#572)

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

build(java): Introduce Native Image testing build script changes (#572 )

3495211

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026

chore(deps): update dependency com.google.cloud:google-cloud-logging …

9ca1683

…to v2.3.2 (googleapis#572)

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(deps): update dependency com.google.cloud:google-cloud-spanner-…

874ba3f

…jdbc to v2.3.5 (googleapis#572)

Make Project a subclass of ProjectInfo by ajkannan · Pull Request #572 · googleapis/google-cloud-java · GitHub

Uh oh!

Make Project a subclass of ProjectInfo - #572

Make Project a subclass of ProjectInfo#572ajkannan merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom ajkannan:project-extends-projectinfoajkannan/gcloud-java:project-extends-projectinfoCopy head branch name to clipboard

Conversation

ajkannan commented Jan 22, 2016

Uh oh!

ajkannan commented Jan 23, 2016

Uh oh!

aozarov commented Jan 23, 2016

Uh oh!

mderka commented Jan 23, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Jan 25, 2016

Uh oh!

mziccard commented Jan 25, 2016

Uh oh!

ajkannan commented Jan 25, 2016

Uh oh!

ajkannan commented Jan 27, 2016

Uh oh!

ajkannan commented Jan 28, 2016

Uh oh!

mziccard commented Jan 28, 2016

Uh oh!

ajkannan commented Jan 29, 2016

Uh oh!

aozarov commented Jan 30, 2016

Uh oh!

ajkannan commented Jan 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Make Project a subclass of ProjectInfo#572
ajkannan merged 1 commit into
googleapis:masterfrom
ajkannan:project-extends-projectinfo