Rename maxResults to pageSize by mziccard · Pull Request #745 · googleapis/google-cloud-java · GitHub

This fixes #740

Looks good. Feel free to merge.

A follow up question though. I ran grep on all .java files that we have in the library. We are still using MAX_RESULTS enum in our Rpc.Option classes. While this is an constant for "maxResults" selector, would it be better to rename this one as well, i.e., to have PAGE_SIZE("maxResults")? If we do this, constructs such as

return new BucketListOption(StorageRpc.Option.MAX_RESULTS, pageSize);

will become

return new BucketListOption(StorageRpc.Option.PAGE_SIZE, pageSize);

I do not have a clear opinion, however, the latter seems a nicer to me. The name switch from "page size" and to "max results" has to happen somewhere and I would probably try to push it as close to the call itself as possible.

/cc @ajkannan @aozarov

The name MAX_RESULTS remained the StorageRpc.Option enum because of the actual name of the parameter that is expected by the JSON API. StorageRpc.Option is not exposed to the user so I think we should stick to this naming as it's a better remainder of the actual param name.

Ok, fine with me.

Rename maxResults to pageSize

🤖 I have created a release *beep* *boop* --- ## [2.4.1](googleapis/java-container@v2.4.0...v2.4.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#745](googleapis/java-container#745)) ([ecba26e](googleapis/java-container@ecba26e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

…-plugin to v3.4.1 (#745) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-javadoc-plugin)) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billingbudgets).

…connection to v2.5.2 (#745) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigqueryconnection](https://togithub.com/googleapis/java-bigqueryconnection) | `2.5.1` -> `2.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.5.2/compatibility-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.5.2/confidence-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigqueryconnection).

…ator_java versions (#745) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

🤖 I have created a release *beep* *boop* --- ## [2.4.5](https://togithub.com/googleapis/java-servicedirectory/compare/v2.4.4...v2.4.5) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([b208d4f](https://togithub.com/googleapis/java-servicedirectory/commit/b208d4fa72fd48d9f5724f3594a05b1b49676363)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

* chore: update github actions * chore: update Source-Link: googleapis/synthtool@1622741 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e3746f84955528d0fe24bf2e4df89875d6ce5a036af01b9c326d61a38838523a

…ependencies to v2 (#745)

…onfig to v1.3.3 (#745)

- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-datastore/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea. **Issue already existed** - [x] Ensure the tests and linter pass **N/A** - [x] Code coverage does not decrease (if any source code was changed) **N/A** - [x] Appropriate docs were updated (if necessary) **Strictly a docs addition** Fixes #745 ☕️ Note: I can confirm that the existing pom.xml works correctly.

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v5` -> `v6` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v6`](https://togithub.com/actions/github-script/compare/v5...v6) [Compare Source](https://togithub.com/actions/github-script/compare/v5...v6) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).

🤖 I have created a release *beep* *boop* --- ### [2.5.11](googleapis/java-spanner-jdbc@v2.5.10...v2.5.11) (2022-02-11) ### Dependencies * update actions/github-script action to v6 ([googleapis#745](googleapis/java-spanner-jdbc#745)) ([0c0d986](googleapis/java-spanner-jdbc@0c0d986)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [0.123.16](https://www.github.com/googleapis/java-storage-nio/compare/v0.123.15...v0.123.16) (2021-10-21) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#744](https://www.github.com/googleapis/java-storage-nio/issues/744)) ([1bd8024](https://www.github.com/googleapis/java-storage-nio/commit/1bd802443ac9e85a74415246aaa66a39c3b769f0)) * update dependency com.google.cloud:google-cloud-storage to v2.1.9 ([#743](https://www.github.com/googleapis/java-storage-nio/issues/743)) ([ddc107d](https://www.github.com/googleapis/java-storage-nio/commit/ddc107d8974b6f8c42358e9188f3cd97336f7368)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

… to v2.8.0 (#745)

… to v2.8.0 (#745)

Rename maxResults to pageSize

d97c188

mziccard added docs type: cleanup An internal cleanup or hygiene concern. labels Mar 14, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2016

mderka self-assigned this Mar 14, 2016

mderka added a commit that referenced this pull request Mar 14, 2016

Merge pull request #745 from mziccard/rename-max-results

9e5c173

Rename maxResults to pageSize

mderka merged commit 9e5c173 into googleapis:master Mar 14, 2016

theacodes unassigned mderka Sep 28, 2018

suztomo pushed a commit that referenced this pull request Feb 1, 2023

chore(deps): update dependency com.google.cloud:google-cloud-shared-d…

86135cb

…ependencies to v2 (#745)

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

e9c96d1

…onfig to v1.3.3 (#745)

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

build: add jdk 17 to java units and dependency builds (#1216 ) (#745 )

10aaf9c

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

build: add jdk 17 to java units and dependency builds (#1216 ) (#745 )

c292832

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

deps: update dependency com.google.errorprone:error_prone_annotations…

554d602

… to v2.8.0 (#745)

meltsufin pushed a commit that referenced this pull request May 1, 2026

deps: update dependency com.google.errorprone:error_prone_annotations…

359131b

… to v2.8.0 (#745)

Rename maxResults to pageSize by mziccard · Pull Request #745 · googleapis/google-cloud-java · GitHub

Uh oh!

Rename maxResults to pageSize - #745

Rename maxResults to pageSize#745
mderka merged 1 commit into
googleapis:masterfrom
mziccard:rename-max-results

mziccard commented Mar 14, 2016

Uh oh!

mderka commented Mar 14, 2016

Uh oh!

mziccard commented Mar 14, 2016

Uh oh!

mderka commented Mar 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rename maxResults to pageSize by mziccard · Pull Request #745 · googleapis/google-cloud-java · GitHub

Uh oh!

Rename maxResults to pageSize - #745

Rename maxResults to pageSize#745mderka merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:rename-max-resultsmziccard/gcloud-java:rename-max-resultsCopy head branch name to clipboard

Conversation

mziccard commented Mar 14, 2016

Uh oh!

mderka commented Mar 14, 2016

Uh oh!

mziccard commented Mar 14, 2016

Uh oh!

mderka commented Mar 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rename maxResults to pageSize#745
mderka merged 1 commit into
googleapis:masterfrom
mziccard:rename-max-results