Remove default contentType from Storage.compose and Bucket.create by mziccard · Pull Request #762 · googleapis/google-cloud-java · GitHub

This fixes #288

Coverage increased (+0.03%) to 83.228% when pulling 8840b33 on mziccard:remove-compose-content-type into 7d48ec7 on GoogleCloudPlatform:master.

Looks great. Thanks for doing that. Should we also add something to the integration test?
Also, I suspect this enforcment is no longer needed?

- update CopyRequest to hold both targetId and targetInfo - avoid sending storage object in StorageRpc.rewrite when only targetId is set - refactor CopyWriter and state - add integration tests

Coverage increased (+1.1%) to 84.321% when pulling 22636e2 on mziccard:remove-compose-content-type into 7d48ec7 on GoogleCloudPlatform:master.

Nice, few more comments/suggestions.

Coverage increased (+1.1%) to 84.318% when pulling 1855ae1 on mziccard:remove-compose-content-type into 7d48ec7 on GoogleCloudPlatform:master.

LGTM. Feel free to merge after considering the 2 comments above.

…iter's StateImpl.target

Coverage increased (+1.1%) to 84.318% when pulling 5dd0292 on mziccard:remove-compose-content-type into 7d48ec7 on GoogleCloudPlatform:master.

Remove default contentType from Storage.compose and Bucket.create

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/java-resourcemanager@v1.2.11...v1.3.0) (2022-04-18) ### Features * AuditConfig for IAM v1 ([googleapis#747](googleapis/java-resourcemanager#747)) ([6806574](googleapis/java-resourcemanager@6806574)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [0.123.2](googleapis/java-datalabeling@v0.123.1...v0.123.2) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-datalabeling/issues/1485)) ([#761](googleapis/java-datalabeling#761)) ([a57a787](googleapis/java-datalabeling@a57a787)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fixes #n/a☕️ Changed the network name being created We were seeing the error where we ran into too many clusters being created with the `default` vpc network, which was also being by other java CI flows not in this repo.

…1.1 (#762) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iot).

…1.4 (#762) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-servicedirectory).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…logback to v0.123.12-alpha (#762) * chore(deps): update dependency com.google.cloud:google-cloud-logging-logback to v0.123.12-alpha * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…e to v2.7.0 (#762) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://togithub.com/googleapis/java-datastore) | `2.6.0` -> `2.7.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-datastore/2.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-datastore/2.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-datastore/2.7.0/compatibility-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-datastore/2.7.0/confidence-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datastore).

…rst iteration (#756) (#762) * chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) * chore: expand imports (#756)

* refactor: Revert JUnit5 to JUnit4 Refactored tests added since 928dd04 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (#756) (#769)" This reverts commit 928dd04. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (#756) (#767)" This reverts commit 59dfb35. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (#756) (#766)" This reverts commit d7edc45. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (#756) (#764)" This reverts commit e9dfaf9. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (#756) (#763)" This reverts commit d045247. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) (#762)" This reverts commit 4e6576f. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (#756) (#761)" This reverts commit a64d35c. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (#756) (#760)" This reverts commit cccaa44.

…rst iteration (#756) (#762) * chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) * chore: expand imports (#756)

* refactor: Revert JUnit5 to JUnit4 Refactored tests added since cdebb54 to use JUnit4 instead of JUnit5. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - sixth iteration (#756) (#769)" This reverts commit cdebb54. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fifth iteration (#756) (#767)" This reverts commit f783380. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - fourth iteration (#756) (#766)" This reverts commit 3463218. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - third iteration (#756) (#764)" This reverts commit ca97388. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - second iteration (#756) (#763)" This reverts commit 9ce44be. Revert "chore: migrate tests in oauth2_http module from JUnit4 to JUnit5 - first iteration (#756) (#762)" This reverts commit 86a4779. Revert "refactor: migration tests in credentials module from JUnit4 to JUnit5 (#756) (#761)" This reverts commit 4054c0b. Revert "refactor: migration tests in appengine module from JUnit4 to JUnit5 (#756) (#760)" This reverts commit a6b04ac.

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added 2 commits March 18, 2016 14:25

Remove default contentType from Storage's compose

0a113cd

Remove default contentType from Bucket's create

8840b33

mziccard added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 18, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016

aozarov reviewed Mar 18, 2016
View reviewed changes

Remove checks for contentType in CopyRequest

22636e2

- update CopyRequest to hold both targetId and targetInfo - avoid sending storage object in StorageRpc.rewrite when only targetId is set - refactor CopyWriter and state - add integration tests

aozarov reviewed Mar 19, 2016
View reviewed changes

Comment thread gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java Outdated

private final Set<BlobTargetOption> targetOptions = new LinkedHashSet<>();

private BlobId source;

private BlobInfo target;

private BlobId targetId;

This comment was marked as spam.

Sign in to view

mziccard added 2 commits March 20, 2016 21:05

Refactor CopyRequest: remove targetId, add boolean overrideInfo

3e5db7a

Add better javadoc to Storage.copy and CopyWriter

1855ae1

aozarov reviewed Mar 20, 2016
View reviewed changes

Rephrase RewriteChannel and Storage.copy javadoc. Add final to CopyWr…

5dd0292

…iter's StateImpl.target

mziccard added a commit that referenced this pull request Mar 20, 2016

Merge pull request #762 from mziccard/remove-compose-content-type

fa64fa5

Remove default contentType from Storage.compose and Bucket.create

mziccard merged commit fa64fa5 into googleapis:master Mar 20, 2016

+                 * @throws StorageException upon failure
+                 */
+                public Blob create(String blob, byte[] content, BlobTargetOption... options) {
+                  BlobInfo blobInfo = BlobInfo.builder(BlobId.of(name(), blob)).build();

                     private final Map<StorageRpc.Option, ?> sourceOptions;
-                    private final BlobId targetId;
+                    private final boolean overrideInfo;
+                    private BlobInfo target;

                     private final Set<BlobTargetOption> targetOptions = new LinkedHashSet<>();
                     private BlobId source;
-                    private BlobInfo target;
+                    private BlobId targetId;

Remove default contentType from Storage.compose and Bucket.create by mziccard · Pull Request #762 · googleapis/google-cloud-java · GitHub

Uh oh!

Remove default contentType from Storage.compose and Bucket.create - #762

Remove default contentType from Storage.compose and Bucket.create#762mziccard merged 6 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:remove-compose-content-typemziccard/gcloud-java:remove-compose-content-typeCopy head branch name to clipboard

Conversation

mziccard commented Mar 18, 2016

Uh oh!

coveralls commented Mar 18, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 18, 2016

Uh oh!

coveralls commented Mar 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 19, 2016

Uh oh!

coveralls commented Mar 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 20, 2016

Uh oh!

coveralls commented Mar 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove default contentType from Storage.compose and Bucket.create#762
mziccard merged 6 commits into
googleapis:masterfrom
mziccard:remove-compose-content-type