feat(firestore): global option to turn on implicit orderby - #7641
Merged
wu-hui merged 3 commits intoMar 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
f565d1f to
ad6901a
Compare
March 17, 2026 15:47
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
3510568 to
f40a641
Compare
March 17, 2026 20:11
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
f40a641 to
7b85096
Compare
March 17, 2026 20:44
MarkDuckworth
approved these changes
Mar 19, 2026
MarkDuckworth
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with suggestions
Sorry, something went wrong.
Comment thread
handwritten/firestore/types/firestore.d.ts
Outdated
| openTelemetry?: FirestoreOpenTelemetryOptions; | ||
| /** | ||
| * Whether to always use implicit order by clauses. | ||
| * @internal |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Remove this @internal tag?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
Comment thread
handwritten/firestore/types/firestore.d.ts
| * Whether to always use implicit order by clauses. | ||
| * @internal | ||
| */ | ||
| get alwaysUseImplicitOrderBy(): boolean; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do you want this property on the Firestore API? And if so, did you intend to leave it internal?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
b3db01e to
7857b40
Compare
March 19, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting: googleapis/java-firestore#2337