This repository was archived by the owner on May 8, 2026. It is now read-only.
feat(firestore): global option to turn on implicit orderby - #2337
Merged
wu-hui merged 2 commits intoMar 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
a855d28 to
84bc5f2
Compare
March 9, 2026 20:32
MarkDuckworth
approved these changes
Mar 11, 2026
MarkDuckworth
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. The JavaDoc comment on the setting could use a little cleanup for readabiliy, but looks good
Sorry, something went wrong.
Comment thread
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java
Outdated
Comment thread
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java
Outdated
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
84bc5f2 to
488db23
Compare
March 17, 2026 13:47
Copy link
Copy Markdown
Contributor
Author
|
Improved the JavaDoc readability for in as requested. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Improved the JavaDoc readability for setAlwaysUseImplicitOrderBy in FirestoreOptions.java as requested. |
Sorry, something went wrong.
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
488db23 to
27db8ca
Compare
March 17, 2026 13:57
wu-hui
force-pushed
the
feat-implicit-orderby
branch
from
dbdc2ac to
979aead
Compare
March 17, 2026 15:24
MarkDuckworth
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new global option alwaysUseImplicitOrderBy in FirestoreOptions to control whether implicit order bys (e.g. for inequality queries) are sent to the backend. By default, it is false (meaning the SDK only sends explicit order bys). Enterprise users can opt-in to always send them by setting this new option to true to mimic Standard tier behavior.
Related modifications: