FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(bigquery): update code samples of load table autodetect and truncate by HemangChothani · Pull Request #10176 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

refactor(bigquery): update code samples of load table autodetect and truncate - #10176

Closed
HemangChothani wants to merge 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_update_load_table_autodetect_truncate_code_sample
ConversationCommits (3)ChecksFiles changed
Closed

refactor(bigquery): update code samples of load table autodetect and truncate#10176
HemangChothani wants to merge 3 commits into
googleapis:masterfrom
MaxxleLLC:bigquery_update_load_table_autodetect_truncate_code_sample

Conversation

HemangChothani commented Jan 21, 2020

Copy link
Copy Markdown
Contributor

Towards #8989

List of changes:

  1. load_table_uri_autodetect_csv
  2. load_table_uri_autodetect_json
  3. load_table_uri_truncate_avro.py
  4. load_table_uri_truncate_json.py
  5. load_table_uri_truncate_csv.py
  6. load_table_uri_truncate_orc.py
  7. load_table_uri_truncate_parquet.py

HemangChothani requested review from a team and tswast January 21, 2020 12:56
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020

plamut commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

(not a complete review in any way, just a remark)

Shouldn't the copyright notice contain the year 2020 in new files?

HemangChothani commented Jan 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

test_client_load_partitioned_table snippet failed is unrelated to changes.

plamut mentioned this pull request Jan 24, 2020
Merged

plamut commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

The failing snippet test is fixed in #10195.

HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
plamut added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2020
plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2020

plamut commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

Starting the repo split, please do not merge.

plamut commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

The repo split for BigQuery is done, please re-open the PR in the new repo, thanks!

https://github.com/googleapis/python-bigquery

plamut commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Superseded by googleapis/python-bigquery#28

plamut closed this Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tswast Awaiting requested review from tswast

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL