test(bigquery): fix snippet test for loading partitioned tables - #10195
Closed
plamut wants to merge 1 commit into
Closed
test(bigquery): fix snippet test for loading partitioned tables#10195plamut wants to merge 1 commit into
plamut wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@shollyman Can you look into why this CSV changed and revert it back to the correct file? Note: we should have a rolling backup of files in the storage-samples project that owns this bucket. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I just looked at the bucket. It was indeed modified at January 22, 2020 at 4:20:49 PM UTC-6. Not sure by whom. $ diff bigquery_us-states_us-states-by-date* 1d0 < name,post_abbr,date 51c50 < Wyoming,WY,1890-07-10 \ No newline at end of file --- > Wyoming,WY,1890-07-10 Looks like the header line was removed and a new line added at the end. Not sure why. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I've restored the file from backup. Closing this PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10194.
For some reason the number of rows in the public test file us-states-by-date.csv has changed from 50 to 49. This PR adjusts the affected test.
PR checklist