[DRAFT] fix(auth): make requests required dependency by daniel-sanche · Pull Request #16100 · googleapis/google-cloud-python · GitHub

Potential fix for #16090, Alternative to #16095

Make requests into required dependency, to avoid import errors when dealing with mTLS. mTLS is currently only supported for the requests.Request class

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with mTLS by making the requests library a mandatory dependency for the google-auth package. This change ensures that the necessary components for mTLS are always available, preventing import errors. Concurrently, the testing infrastructure has been improved by reorganizing test dependencies into minimal and extended sets, streamlining the testing process and optimizing resource usage.

Highlights

Core Dependency Update: The requests library has been promoted from an optional extra to a required core dependency in google-auth to address potential mTLS import errors.
Testing Configuration Refactor: The testing setup has been refactored to introduce testing_minimal_require and testing_extra_require, allowing for more granular control over test dependencies and reducing CI load for extended tests.
Noxfile Adjustments: The noxfile.py has been updated to align with the new testing dependency structure, renaming a parameter and modifying the logic for installing test extras.

Changelog

packages/google-auth/noxfile.py
- Renamed the install_deprecated_extras parameter to install_extras in the unit session.
- Updated the conditional logic for installing test dependencies to use install_extras and differentiate between testing and testing_minimal profiles.
- Removed the explicit installation of oauth2client as it is now handled by the setup.py extras.
packages/google-auth/setup.py
- Moved requests from requests_extra_require to requests_base_require and included it in the main DEPENDENCIES tuple, making it a required dependency.
- Adjusted aiohttp_extra_require to no longer include requests_extra_require since requests is now a base dependency.
- Introduced testing_minimal_require to define a baseline set of test dependencies.
- Refactored testing_extra_require to build upon testing_minimal_require and explicitly include pyjwt, pyopenssl, reauth, urllib3, aiohttp, aioresponses, oauth2client, and rsa related dependencies.
- Added testing_minimal to the extras dictionary to support the new minimal testing profile.

Activity

No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Code Review

This pull request makes requests a required dependency to address import errors with mTLS. The changes correctly move requests to the core dependencies in setup.py and refactor the testing setup in both noxfile.py and setup.py to accommodate a minimal test configuration. However, I've found critical syntax errors in the testing_extra_require list within setup.py that need to be fixed to ensure the package can be installed correctly.

The definition of testing_extra_require contains syntax errors, including missing commas and a duplicated dependency (*pyopenssl_extra_require). These issues will cause a SyntaxError when setup.py is parsed, breaking package installation.

testing_extra_require = [
    *testing_minimal_require,
    *pyjwt_extra_require,
    *pyopenssl_extra_require,
    *reauth_extra_require,
    *urllib3_extra_require,
    # Async Dependencies
    *aiohttp_extra_require,
    # TODO(https://github.com/googleapis/google-auth-library-python/issues/1722): `test_aiohttp_requests` depend on
    # aiohttp < 3.10.0 which is a bug. Investigate and remove the pinned aiohttp version.
    "aiohttp < 3.10.0",
    "aioresponses",
    "oauth2client",
    *rsa_extra_require,
]

Closing in favor of #16480

daniel-sanche added 2 commits March 12, 2026 14:45

make requests into required dependency

4e1b845

improve how extras are handled

5253054

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

daniel-sanche mentioned this pull request Mar 12, 2026

[DRAFT] fix(auth): disable mds mtls if requests isn't present #16095

Closed

added missing ,

857b483

daniel-sanche mentioned this pull request Mar 12, 2026

feat: implement updated design for regional access boundary #16084

Merged

daniel-sanche closed this Mar 30, 2026

[DRAFT] fix(auth): make requests required dependency by daniel-sanche · Pull Request #16100 · googleapis/google-cloud-python · GitHub

Uh oh!

[DRAFT] fix(auth): make requests required dependency - #16100

[DRAFT] fix(auth): make requests required dependency#16100
daniel-sanche wants to merge 3 commits into
mainfrom
auth_require_requests

daniel-sanche commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 12, 2026

Uh oh!

daniel-sanche commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

[DRAFT] fix(auth): make requests required dependency by daniel-sanche · Pull Request #16100 · googleapis/google-cloud-python · GitHub

Uh oh!

[DRAFT] fix(auth): make requests required dependency - #16100

[DRAFT] fix(auth): make requests required dependency#16100daniel-sanche wants to merge 3 commits intomaingoogleapis/google-cloud-python:mainfrom auth_require_requestsgoogleapis/google-cloud-python:auth_require_requestsCopy head branch name to clipboard

Conversation

daniel-sanche commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot commented Mar 12, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-sanche commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

[DRAFT] fix(auth): make requests required dependency#16100
daniel-sanche wants to merge 3 commits into
mainfrom
auth_require_requests