FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[DRAFT] fix(auth): make requests required dependency by daniel-sanche · Pull Request #16100 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

[DRAFT] fix(auth): make requests required dependency #16100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel-sanche wants to merge 3 commits into from
Conversation 4 Commits 3 Checks 23 Files changed
Closed

[DRAFT] fix(auth): make requests required dependency #16100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1b845
make requests into required dependency
daniel-sanche Mar 12, 2026
5253054
improve how extras are handled
daniel-sanche Mar 12, 2026
857b483
added missing ,
daniel-sanche Mar 12, 2026
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
16 changes: 7 additions & 9 deletions packages/google-auth/noxfile.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,14 @@ def mypy(session):


@nox.session(python=ALL_PYTHON)
@nox.parametrize(["install_deprecated_extras"], (True, False))
def unit(session, install_deprecated_extras):
@nox.parametrize(["install_extras"], (True, False))
def unit(session, install_extras):
# Install all test dependencies, then install this package in-place.

if session.python in ("3.7",):
session.skip("Python 3.7 is no longer supported")
min_py, max_py = UNIT_TEST_PYTHON_VERSIONS[0], UNIT_TEST_PYTHON_VERSIONS[-1]
if not install_deprecated_extras and session.python not in (min_py, max_py):
if not install_extras and session.python not in (min_py, max_py):
# only run double tests on first and last supported versions
session.skip(
f"Extended tests only run on boundary Python versions ({min_py}, {max_py}) to reduce CI load."
Expand All @@ -131,12 +131,10 @@ def unit(session, install_deprecated_extras):
constraints_path = str(
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
)
extras_str = "testing"
if install_deprecated_extras:
# rsa and oauth2client were both archived and support dropped,
# but we still test old code paths
session.install("oauth2client")
extras_str += ",rsa"
if install_extras:
extras_str = "testing"
else:
extras_str = "testing_minimal"
session.install("-e", f".[{extras_str}]", "-c", constraints_path)
session.run(
"pytest",
Expand Down
31 changes: 19 additions & 12 deletions packages/google-auth/setup.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,16 @@
"cryptography >= 38.0.3",
]

requests_base_require = ["requests >= 2.20.0, < 3.0.0"]

DEPENDENCIES = (
"pyasn1-modules>=0.2.1",
cryptography_base_require,
requests_base_require,
)

requests_extra_require = ["requests >= 2.20.0, < 3.0.0"]

aiohttp_extra_require = ["aiohttp >= 3.6.2, < 4.0.0", *requests_extra_require]
aiohttp_extra_require = ["aiohttp >= 3.6.2, < 4.0.0"]

pyjwt_extra_require = ["pyjwt>=2.0"]

Expand All @@ -46,32 +48,36 @@
rsa_extra_require = ["rsa>=3.1.4,<5"]

# Unit test requirements.
testing_extra_require = [
testing_minimal_require = [
# TODO(https://github.com/googleapis/google-auth-library-python/issues/1735): Remove `grpcio` from testing requirements once an extra is added for `grpcio` dependency.
"grpcio",
"flask",
"freezegun",
*pyjwt_extra_require,
"pytest",
"pytest-cov",
"pytest-localserver",
"responses",
"pytest-asyncio",
]

testing_extra_require = [
*testing_minimal_require,
*pyjwt_extra_require,
*pyopenssl_extra_require,
*reauth_extra_require,
"responses",
*urllib3_extra_require,
# Async Dependencies
*aiohttp_extra_require,
"aioresponses",
"pytest-asyncio",
# TODO(https://github.com/googleapis/google-auth-library-python/issues/1665): Remove the pinned version of pyopenssl
# once `TestDecryptPrivateKey::test_success` is updated to remove the deprecated `OpenSSL.crypto.sign` and
# `OpenSSL.crypto.verify` methods. See: https://www.pyopenssl.org/en/latest/changelog.html#id3.
"pyopenssl < 24.3.0",
# TODO(https://github.com/googleapis/google-auth-library-python/issues/1722): `test_aiohttp_requests` depend on
# aiohttp < 3.10.0 which is a bug. Investigate and remove the pinned aiohttp version.
"aiohttp < 3.10.0",
*pyopenssl_extra_require,
"aioresponses",
"oauth2client",
*rsa_extra_require,
]
Comment on lines +63 to 78

gemini-code-assist Bot Mar 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The definition of testing_extra_require contains syntax errors, including missing commas and a duplicated dependency (*pyopenssl_extra_require). These issues will cause a SyntaxError when setup.py is parsed, breaking package installation.

testing_extra_require = [
    *testing_minimal_require,
    *pyjwt_extra_require,
    *pyopenssl_extra_require,
    *reauth_extra_require,
    *urllib3_extra_require,
    # Async Dependencies
    *aiohttp_extra_require,
    # TODO(https://github.com/googleapis/google-auth-library-python/issues/1722): `test_aiohttp_requests` depend on
    # aiohttp < 3.10.0 which is a bug. Investigate and remove the pinned aiohttp version.
    "aiohttp < 3.10.0",
    "aioresponses",
    "oauth2client",
    *rsa_extra_require,
]


extras = {
# Note: cryptography was made into a required dependency. Extra is kept for backwards compatibility
"cryptography": cryptography_base_require,
Expand All @@ -80,8 +86,9 @@
"pyopenssl": pyopenssl_extra_require,
"pyjwt": pyjwt_extra_require,
"reauth": reauth_extra_require,
"requests": requests_extra_require,
"requests": requests_base_require,
"testing": testing_extra_require,
"testing_minimal": testing_minimal_require,
"urllib3": urllib3_extra_require,
"rsa": rsa_extra_require,
# TODO(https://github.com/googleapis/google-auth-library-python/issues/1735): Add an extra for `grpcio` dependency.
Expand Down
Loading
Back | FazBrowse Home | New Git URL