Add system test for 'Client.list_metrics'. - #1611
Merged
tseaver merged 1 commit intoMar 18, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Mar 15, 2016
Adjust 'Metric.from_api_repr' and associated tests to accomodate the fact that the 'LogMetric' resource does not contain a fully-qualified path, but only the simple name.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Comment thread
gcloud/logging/metric.py
| from the client. | ||
| """ | ||
| metric_name = _metric_name_from_path(resource['name'], client.project) | ||
| metric_name = resource['name'] |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Side question: Can we turn these on to run in Travis? |
Sorry, something went wrong.
Comment thread
system_tests/logging_.py
| DEFAULT_METRIC_NAME, DEFAULT_FILTER, DEFAULT_DESCRIPTION) | ||
| self.assertFalse(metric.exists()) | ||
| before_metrics, _ = Config.CLIENT.list_metrics() | ||
| before_names = set(metric.name for metric in before_metrics) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
The Sink tests (only #1628, at present) are the ones which will need the Owner role for the project. The others should work fine. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
tseaver
added a commit
that referenced
this pull request
Mar 18, 2016
…_metrics Add system test for 'Client.list_metrics'.
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
…1611) Source-Link: googleapis/synthtool@d6103f4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This test is causing failures in CI. Skipping until it can be fixed properly. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #1611 🦕
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #1610 as a base.
Note the changes to gcloud.logging: the system test revealed that the API returns "simple" names for the LogMetric resource (as documented, but which I misread as returning fully-qualified paths).