FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add system test for 'Sink.create', w/ Storage bucket destination by tseaver · Pull Request #1628 · googleapis/google-cloud-python · GitHub

Add system test for 'Sink.create', w/ Storage bucket destination - #1628

Merged
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-sink_create
Mar 22, 2016
Merged

Add system test for 'Sink.create', w/ Storage bucket destination#1628
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-sink_create

Conversation

tseaver commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

Uses #1613 as a base.

tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 17, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2016
tseaver changed the title Add system test for 'Sink.create'. Add system test for 'Sink.create', w/ Storage bucket destination Mar 17, 2016

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

LGTM pending rebase.

Also, FWIW if you rebase both this and #1613, then merge this, then GitHub will auto-close #1613 as merged.

tseaver commented Mar 18, 2016

Copy link
Copy Markdown
Contributor Author

N.B. that we cannot merge this PR until we have solved the problem outlined in #1614 (system tests have to run as a user with permission to create / update / delete sinks, i.e. with Owner role).

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

Noted

tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 18, 2016
tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 22, 2016
tseaver added a commit that referenced this pull request Mar 22, 2016
Add system test for 'Sink.create', w/ Storage bucket destination
tseaver merged commit 0adbd70 into googleapis:logging-api Mar 22, 2016
tseaver deleted the logging-system_test-sink_create branch March 22, 2016 16:13
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: blob.display to support width and height params

* wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL