fix(bigtable): data client should acknowledge all mutations in batch - #18124
Conversation
Sorry, something went wrong.
…dged Change-Id: I9a166818c5829b446553fc1427d1f1d1ec078d0d
There was a problem hiding this comment.
Code Review
This pull request introduces a response completeness check to both the async and sync implementations of _mutate_rows.py, ensuring that any mutation entries not acknowledged by the server are explicitly failed with a ClientError rather than being silently treated as successful. While the added test coverage is thorough, the reviewer correctly identified a critical bug in both implementations: when mutations are retried across multiple attempts, obsolete acknowledgments and errors from previous attempts are not cleared, which prevents the completeness check from correctly identifying silently dropped entries in subsequent attempts. To resolve this, the state of retried entries should be cleared at the start of each attempt.
Sorry, something went wrong.
|
Did your original approach not work? I thought that seemed like a good solution. Gemini pointed out some issues with the new approach. It could be difficult to keep a global _acknowledged_indices map up-to-date, because each attempt is another chance to drop a mutation. It would be better if we could keep all the per-attempt state within _run_attempt |
Sorry, something went wrong.
…ead of a count check Change-Id: I4ce3e38536a6aa6270806868074eb51c7832653a
🤖 I have created a release *beep* *boop* --- ## [2.42.0](google-cloud-bigtable-v2.41.0...google-cloud-bigtable-v2.42.0) (2026-08-19) ### Features * **bigtable:** client side metrics handlers ([#16760](#16760)) ([43b786c](43b786c)) * **bigtable:** initialize internal data client in classic client ([#18080](#18080)) ([92008e2](92008e2)) ### Bug Fixes * **bigtable:** data client should acknowledge all mutations in batch ([#18124](#18124)) ([e7f6a34](e7f6a34)) * **bigtable:** report swallowed batch flush errors and unacknowledged entries ([#18122](#18122)) ([2fe5bdc](2fe5bdc)) * **bigtable:** standardize client side metrics ([#17899](#17899)) ([a69e2cb](a69e2cb)) * **bigtable:** surface batcher flush errors and disable timer ([#18145](#18145)) ([fac536e](fac536e)) * bump grpcio to 1.59.0; require Python 3.10+ ([#17351](#17351)) ([a53487a](a53487a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fail V3 mutate_rows entries the server never acknowledged