fix(bigtable): surface batcher flush errors and disable timer - #18145
Merged
mutianf merged 2 commits intoAug 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…op one-shot timer Change-Id: I046bb0ee2c92ef20f842dea8eb5480e85717e87e
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates the background timer-based flush in MutationsBatcher and updates the close() method to handle exceptions during the final synchronous flush, ensuring that executor shutdown and cleanup are not aborted. The reviewer pointed out that catching a generic Exception in close() could lead to nested MutationsBatchError exceptions, and suggested explicitly catching and unpacking MutationsBatchError to maintain a flat list of exceptions.
Sorry, something went wrong.
sushanb
approved these changes
Aug 18, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mutianf
enabled auto-merge (squash)
August 18, 2026 21:01
daniel-sanche
approved these changes
Aug 18, 2026
mutianf
disabled auto-merge
August 18, 2026 21:13
parthea
pushed a commit
that referenced
this pull request
Aug 19, 2026
🤖 I have created a release *beep* *boop* --- ## [2.42.0](google-cloud-bigtable-v2.41.0...google-cloud-bigtable-v2.42.0) (2026-08-19) ### Features * **bigtable:** client side metrics handlers ([#16760](#16760)) ([43b786c](43b786c)) * **bigtable:** initialize internal data client in classic client ([#18080](#18080)) ([92008e2](92008e2)) ### Bug Fixes * **bigtable:** data client should acknowledge all mutations in batch ([#18124](#18124)) ([e7f6a34](e7f6a34)) * **bigtable:** report swallowed batch flush errors and unacknowledged entries ([#18122](#18122)) ([2fe5bdc](2fe5bdc)) * **bigtable:** standardize client side metrics ([#17899](#17899)) ([a69e2cb](a69e2cb)) * **bigtable:** surface batcher flush errors and disable timer ([#18145](#18145)) ([fac536e](fac536e)) * bump grpcio to 1.59.0; require Python 3.10+ ([#17351](#17351)) ([a53487a](a53487a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕