FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: generate client, transport, and unit test templates for resumable uploads by parthea · Pull Request #18495 · googleapis/google-cloud-python · GitHub

  1. googleapis
  2. google-cloud-python

Repository navigation

feat: generate client, transport, and unit test templates for resumable uploads - #18495

Merged
parthea merged 45 commits into
mainfrom
add-support-for-resumable-uploads-2
Oct 6, 2026
ConversationCommits (45)ChecksFiles changed
Merged

feat: generate client, transport, and unit test templates for resumable uploads#18495
parthea merged 45 commits into
mainfrom
add-support-for-resumable-uploads-2

Conversation

parthea commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

  • Add client, transport, and unit test template support for resumable upload RPCs.

  • Resumable upload methods accept an optional ResumableUploadConfig on the client and return ResumableUploadSession / AsyncResumableUploadSession from google.api_core.resumable_transfer. Since resumable uploads use HTTP, the gRPC and gRPC-async transports delegate resumable upload calls to the corresponding REST transport.

gemini-code-assist Bot reviewed Sep 29, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request adds support for resumable upload methods in the GAPIC generator, wrapping responses in ResumableUploadSession or AsyncResumableUploadSession and ensuring these methods route over REST even when gRPC transport is initialized. It updates templates, transports, and unit tests to support this protocol. The reviewer identified a critical issue in grpc_asyncio.py.j2 where AsyncRestTransport is instantiated on every call, which is highly inefficient and causes resource leaks; they suggested caching the transport instance instead.

Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
parthea changed the title feat: add support for resumable uploads feat: generate client, transport, and unit test templates for resumable uploads Sep 29, 2026
parthea marked this pull request as ready for review September 29, 2026 18:43
parthea requested a review from a team as a code owner September 29, 2026 18:43
parthea added this pull request to stack #18500 September 29, 2026 19:13
daniel-sanche requested changes Sep 29, 2026
View reviewed changes

daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems like there could be some runtime issues here. Can you make sure we have full coverage?

Comment thread ...n/goldens/showcase/google/showcase_v1beta1/services/resumable_upload_service/async_client.py
Comment thread ...ges/gapic-generator/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Comment thread ...enerator/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2
Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
Comment thread ...rator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2 Outdated
Comment thread ...generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2
parthea force-pushed the add-support-for-resumable-uploads-2 branch from b7f0140 to 5282533 Compare September 30, 2026 15:03

snippet-bot Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

parthea force-pushed the add-support-for-resumable-uploads-2 branch from ce31648 to 2c60a8c Compare September 30, 2026 18:06
parthea removed this pull request from stack #18500 September 30, 2026 18:15
parthea changed the base branch from main to remove-compliance-proto September 30, 2026 18:16
parthea added this pull request to stack #18517 September 30, 2026 19:16
parthea force-pushed the add-support-for-resumable-uploads-2 branch from a33d1fe to 389dbfb Compare September 30, 2026 20:23
Base automatically changed from remove-compliance-proto to main September 30, 2026 20:30
parthea force-pushed the add-support-for-resumable-uploads-2 branch from 1ddea43 to 8e785c8 Compare September 30, 2026 20:30
daniel-sanche requested changes Oct 1, 2026
View reviewed changes
Comment thread ...rator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 Outdated
Comment thread ...generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2 Outdated
Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2
Comment thread packages/gapic-generator/noxfile.py Outdated
Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
parthea force-pushed the add-support-for-resumable-uploads-2 branch from 39c26aa to f8fa453 Compare October 1, 2026 20:54
daniel-sanche requested changes Oct 2, 2026
View reviewed changes

daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wanted to bring all my remaining comments into one place, although I know some of these are already being addressed

Comment thread packages/gapic-generator/gapic/templates/setup.py.j2 Outdated
Comment thread ...generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2 Outdated
Comment thread ...apic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
Comment thread ...rator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2
Comment thread ...generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2
Comment thread ...howcase/google/showcase_v1beta1/services/resumable_upload_service/transports/rest_asyncio.py Outdated
Comment thread ...howcase/google/showcase_v1beta1/services/resumable_upload_service/transports/rest_asyncio.py Outdated
Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
parthea force-pushed the add-support-for-resumable-uploads-2 branch 4 times, most recently from aee4eef to e20d380 Compare October 3, 2026 00:53
parthea force-pushed the add-support-for-resumable-uploads-2 branch from 9425277 to dd724d6 Compare October 5, 2026 17:41
parthea requested a review from daniel-sanche October 5, 2026 18:05
parthea assigned daniel-sanche and unassigned parthea Oct 5, 2026
daniel-sanche approved these changes Oct 5, 2026
View reviewed changes

daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
Comment thread ...pic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2 Outdated
parthea closed this Oct 5, 2026
parthea reopened this Oct 5, 2026
parthea closed this Oct 5, 2026
parthea reopened this Oct 5, 2026
parthea closed this Oct 5, 2026
parthea reopened this Oct 5, 2026
parthea closed this Oct 5, 2026
parthea reopened this Oct 5, 2026
parthea closed this Oct 5, 2026
parthea reopened this Oct 5, 2026
parthea merged commit 3f8d00b into main Oct 6, 2026
123 checks passed
parthea deleted the add-support-for-resumable-uploads-2 branch October 6, 2026 00:19
release-please Bot mentioned this pull request Oct 6, 2026
Merged
noahdietz pushed a commit that referenced this pull request Oct 8, 2026
chore: release main (#18572)
3720106 
🤖 I have created a release *beep* *boop*
---


<details><summary>gapic-generator: 1.43.0</summary>

##
[1.43.0](gapic-generator-v1.42.0...gapic-generator-v1.43.0)
(2026-10-08)


### Features

* **gapic-generator:** generate code samples for resumable upload RPCs
([#18501](#18501))
([c8926ab](c8926ab))
* generate client, transport, and unit test templates for resumable
uploads
([#18495](#18495))
([3f8d00b](3f8d00b))
* **observability:** implement universal 4-path OpenTelemetry tracing
([#18433](#18433))
([7d18b25](7d18b25))
</details>

<details><summary>google-ads-admanager: 0.10.7</summary>

##
[0.10.7](google-ads-admanager-v0.10.6...google-ads-admanager-v0.10.7)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-api-core: 2.42.0</summary>

##
[2.42.0](google-api-core-v2.41.0...google-api-core-v2.42.0)
(2026-10-08)


### Features

* **observability:** implement universal 4-path OpenTelemetry tracing
([#18433](#18433))
([7d18b25](7d18b25))
</details>

<details><summary>google-cloud-apphub: 0.5.2</summary>

##
[0.5.2](google-cloud-apphub-v0.5.1...google-cloud-apphub-v0.5.2)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-beyondcorp-appconnections:
0.8.2</summary>

##
[0.8.2](google-cloud-beyondcorp-appconnections-v0.8.1...google-cloud-beyondcorp-appconnections-v0.8.2)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-beyondcorp-appconnectors: 0.8.2</summary>

##
[0.8.2](google-cloud-beyondcorp-appconnectors-v0.8.1...google-cloud-beyondcorp-appconnectors-v0.8.2)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-beyondcorp-appgateways: 0.8.2</summary>

##
[0.8.2](google-cloud-beyondcorp-appgateways-v0.8.1...google-cloud-beyondcorp-appgateways-v0.8.2)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-bigtable: 2.50.0</summary>

##
[2.50.0](google-cloud-bigtable-v2.49.0...google-cloud-bigtable-v2.50.0)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-compute-v1beta: 0.12.8</summary>

##
[0.12.8](google-cloud-compute-v1beta-v0.12.7...google-cloud-compute-v1beta-v0.12.8)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-dialogflow: 2.53.0</summary>

##
[2.53.0](google-cloud-dialogflow-v2.52.0...google-cloud-dialogflow-v2.53.0)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-dialogflow-cx: 2.9.0</summary>

##
[2.9.0](google-cloud-dialogflow-cx-v2.8.0...google-cloud-dialogflow-cx-v2.9.0)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-firestore: 2.34.1</summary>

##
[2.34.1](google-cloud-firestore-v2.34.0...google-cloud-firestore-v2.34.1)
(2026-10-08)


### Bug Fixes

* **firestore:** add generic typing for DocumentSnapshot
([#18587](#18587))
([947949b](947949b))
</details>

<details><summary>google-cloud-netapp: 0.10.3</summary>

##
[0.10.3](google-cloud-netapp-v0.10.2...google-cloud-netapp-v0.10.3)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-redis-cluster: 0.5.4</summary>

##
[0.5.4](google-cloud-redis-cluster-v0.5.3...google-cloud-redis-cluster-v0.5.4)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-cloud-storage: 3.17.0</summary>

##
[3.17.0](google-cloud-storage-v3.16.0...google-cloud-storage-v3.17.0)
(2026-10-08)


### Features

* **storage:** add OpenTelemetry metrics gating and configuration module
([#18407](#18407))
([654e768](654e768))
</details>

<details><summary>google-developer-knowledge: 0.1.4</summary>

##
[0.1.4](google-developer-knowledge-v0.1.3...google-developer-knowledge-v0.1.4)
(2026-10-08)


### Features

* update API sources and regenerate
([#18593](#18593))
([d0505e8](d0505e8))
</details>

<details><summary>google-devicesandservices-health: 0.1.4</summary>

##
[0.1.4](google-devicesandservices-health-v0.1.3...google-devicesandservices-health-v0.1.4)
(2026-10-08)


### Features

* **google-devicesandservices-health:** add v4beta
([#18597](#18597))
([d28458c](d28458c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ohmayr ohmayr left review comments
daniel-sanche daniel-sanche approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

daniel-sanche

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL