Repository navigation
feat(gapic-generator): generate code samples for resumable upload RPCs - #18501
Merged
parthea merged 3 commits intoOct 6, 2026
Merged
parthea merged 3 commits into
parthea merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
parthea
changed the base branch from
add-support-for-resumable-uploads-2
to
main
September 29, 2026 19:15
parthea
changed the base branch from
main
to
add-support-for-resumable-uploads-2
September 29, 2026 19:15
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for generating resumable upload samples in the GAPIC generator, updating templates and generator logic to output sync and async sample options (direct upload, upload with progress, resume, and resume with progress). The review feedback highlights a critical issue where generating multiple sample functions in a single file breaks the snippet metadata parser, leading to malformed segment mappings in the golden files. Additionally, the feedback identifies that upload and resume are incorrectly used as async iterables in the progress-based async samples, and recommends using iter_upload and iter_resume instead to match the sync patterns.
Sorry, something went wrong.
parthea
added this pull request to stack #18517
September 30, 2026 19:16
parthea
force-pushed
the
add-support-for-resumable-uploads-3
branch
from
266853b to
120afed
Compare
September 30, 2026 19:21
parthea
force-pushed
the
add-support-for-resumable-uploads-3
branch
from
120afed to
ddfe327
Compare
September 30, 2026 20:45
parthea
force-pushed
the
add-support-for-resumable-uploads-3
branch
2 times, most recently
from
70e5532 to
a503b35
Compare
October 5, 2026 19:31
parthea
marked this pull request as ready for review
October 5, 2026 20:09
Comment thread
...n/goldens/showcase/google/showcase_v1beta1/services/resumable_upload_service/async_client.py
Comment thread
...generated_samples/localhost_v1beta1_generated_resumable_upload_service_upload_media_async.py
Comment thread
...n/goldens/showcase/google/showcase_v1beta1/services/resumable_upload_service/async_client.py
Outdated
Comment thread
...ion/goldens/showcase/samples/generated_samples/snippet_metadata_google.showcase.v1beta1.json
Outdated
Comment thread
...ion/goldens/showcase/samples/generated_samples/snippet_metadata_google.showcase.v1beta1.json
Outdated
daniel-sanche
approved these changes
Oct 5, 2026
daniel-sanche
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
parthea
force-pushed
the
add-support-for-resumable-uploads-3
branch
from
76de9bf to
fb5980a
Compare
October 6, 2026 00:06
parthea
force-pushed
the
add-support-for-resumable-uploads-3
branch
from
fb5980a to
d3a2870
Compare
October 6, 2026 00:19
Merged
noahdietz
pushed a commit
that referenced
this pull request
Oct 8, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>gapic-generator: 1.43.0</summary> ## [1.43.0](gapic-generator-v1.42.0...gapic-generator-v1.43.0) (2026-10-08) ### Features * **gapic-generator:** generate code samples for resumable upload RPCs ([#18501](#18501)) ([c8926ab](c8926ab)) * generate client, transport, and unit test templates for resumable uploads ([#18495](#18495)) ([3f8d00b](3f8d00b)) * **observability:** implement universal 4-path OpenTelemetry tracing ([#18433](#18433)) ([7d18b25](7d18b25)) </details> <details><summary>google-ads-admanager: 0.10.7</summary> ## [0.10.7](google-ads-admanager-v0.10.6...google-ads-admanager-v0.10.7) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-api-core: 2.42.0</summary> ## [2.42.0](google-api-core-v2.41.0...google-api-core-v2.42.0) (2026-10-08) ### Features * **observability:** implement universal 4-path OpenTelemetry tracing ([#18433](#18433)) ([7d18b25](7d18b25)) </details> <details><summary>google-cloud-apphub: 0.5.2</summary> ## [0.5.2](google-cloud-apphub-v0.5.1...google-cloud-apphub-v0.5.2) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-beyondcorp-appconnections: 0.8.2</summary> ## [0.8.2](google-cloud-beyondcorp-appconnections-v0.8.1...google-cloud-beyondcorp-appconnections-v0.8.2) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-beyondcorp-appconnectors: 0.8.2</summary> ## [0.8.2](google-cloud-beyondcorp-appconnectors-v0.8.1...google-cloud-beyondcorp-appconnectors-v0.8.2) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-beyondcorp-appgateways: 0.8.2</summary> ## [0.8.2](google-cloud-beyondcorp-appgateways-v0.8.1...google-cloud-beyondcorp-appgateways-v0.8.2) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-bigtable: 2.50.0</summary> ## [2.50.0](google-cloud-bigtable-v2.49.0...google-cloud-bigtable-v2.50.0) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-compute-v1beta: 0.12.8</summary> ## [0.12.8](google-cloud-compute-v1beta-v0.12.7...google-cloud-compute-v1beta-v0.12.8) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-dialogflow: 2.53.0</summary> ## [2.53.0](google-cloud-dialogflow-v2.52.0...google-cloud-dialogflow-v2.53.0) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-dialogflow-cx: 2.9.0</summary> ## [2.9.0](google-cloud-dialogflow-cx-v2.8.0...google-cloud-dialogflow-cx-v2.9.0) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-firestore: 2.34.1</summary> ## [2.34.1](google-cloud-firestore-v2.34.0...google-cloud-firestore-v2.34.1) (2026-10-08) ### Bug Fixes * **firestore:** add generic typing for DocumentSnapshot ([#18587](#18587)) ([947949b](947949b)) </details> <details><summary>google-cloud-netapp: 0.10.3</summary> ## [0.10.3](google-cloud-netapp-v0.10.2...google-cloud-netapp-v0.10.3) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-redis-cluster: 0.5.4</summary> ## [0.5.4](google-cloud-redis-cluster-v0.5.3...google-cloud-redis-cluster-v0.5.4) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-cloud-storage: 3.17.0</summary> ## [3.17.0](google-cloud-storage-v3.16.0...google-cloud-storage-v3.17.0) (2026-10-08) ### Features * **storage:** add OpenTelemetry metrics gating and configuration module ([#18407](#18407)) ([654e768](654e768)) </details> <details><summary>google-developer-knowledge: 0.1.4</summary> ## [0.1.4](google-developer-knowledge-v0.1.3...google-developer-knowledge-v0.1.4) (2026-10-08) ### Features * update API sources and regenerate ([#18593](#18593)) ([d0505e8](d0505e8)) </details> <details><summary>google-devicesandservices-health: 0.1.4</summary> ## [0.1.4](google-devicesandservices-health-v0.1.3...google-devicesandservices-health-v0.1.4) (2026-10-08) ### Features * **google-devicesandservices-health:** add v4beta ([#18597](#18597)) ([d28458c](d28458c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sample generation support for resumable upload RPCs.
Generated sync and async snippets demonstrate creating an upload session with ResumableUploadConfig, uploading a stream directly, iterating over UploadProgress updates per chunk, and resuming an interrupted upload from a saved session URL.