FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Recommend new ADC command by waprin · Pull Request #1851 · googleapis/google-cloud-python · GitHub

Recommend new ADC command - #1851

Merged
tseaver merged 1 commit into
googleapis:masterfrom
waprin:master
Jun 10, 2016
Merged

Recommend new ADC command#1851
tseaver merged 1 commit into
googleapis:masterfrom
waprin:master

Conversation

waprin commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

gcloud has a new command for creating ADC. The idea is that gcloud auth login is for authenticating the CLI and gcloud beta auth application-default login creates credentials for client code. After a transition period, gcloud auth login will no longer write credentials to a well-known file and so will not work.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2016

tseaver commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

@waprin How new is the ADC command? Are our users likely to be using older gcloud CLI without it?

waprin commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

It came out in late March. I would say most users should be updating their gcloud frequently enough that they should have it. Our official auth docs recommend it instead of gcloud auth login.

It is still in beta and it's a confusing change so I don't blame you if you want to hold off. However I asked the PM responsible for auth on the platform and he told me I should recommend the change (with apologies for the confusion). And again, sooner or later this change will be necessary since gcloud auth login will stop writing the credentials.

tseaver commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

Maybe the last graph should add a sentence pointing to the docs for updating the gcloud CLI? Something like:

Previously, gcloud auth login was used for both use cases. If your gcloud installation does not support the new commend, please update it: see {URL HERE}.

tseaver self-assigned this Jun 10, 2016

waprin commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

The CLI can update itself so I just added the command to do that.

tseaver merged commit c252631 into googleapis:master Jun 10, 2016

tseaver commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

@waprin Thanks for the patch!

tseaver mentioned this pull request Jun 15, 2016
7 tasks
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Mar 6, 2026
Testing for prerelease-deps is done within continuous.

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL