@tseaver, what do you think about merging in #1815 and #1844 for this release?

@tseaver, #1844 got merged and I'm inclined to leave #1813 out unless we can merge it today. But I'm not sure about #1815?

I just merged #1815. I think we should merge #1813 today, and then make a release.

$ git log -1 --pretty=%H
a74ed9e3e8a8abbe46ca7968ed21cb9a1762dda9
$ git log 0.15.0..HEAD | grep 'Merge pull request ' |  awk -F ' ' '{print $4}' | sort

yields:

#1815
#1816
#1843
#1848
#1851
#1855
#1861

0.16.0 Release Notes

Core

• Install grpcio and related helpers by default on Python 2.7. (Making grpcio install require fewer keystrokes. #1815)
• Recommend new gcloud ADC command for authentication. (Recommend new ADC command #1851)
• Made snippet execution Py3k compatible. (Py3k compatibility for snippet execution. #1860)
• Load project ID from JSON credentials file. (Get project ID from JSON credentials file #1813)

Datastore

• Add support for explicit transactional/serialized reads in Client.get and Client.get_multi. (Add support for serialized/transactional read in 'Client.get{,_multi}'. #1861)

Storage

• Add support for user-supplied encryption to stored blobs. (Add customer-supplied encryption to storage #1844)

Pubsub

• Select API helpers based on presence of gRPC libraries. Enable pubsub-over-GRPC via an environment variable. (Select API helper based on presence of grpcio + optional environment marker #1816, Add support for controlled paging via Gax. #1855, Disable pubsub-over-gax by default. #1874)

Bigtable

• Wrap gRPC "already exists" error with a HappyBase exception. (Wrapping gRPC "already exists" with a HappyBase exception. #1843)

Logging

• Optimize Logger.list_entries query, improve docs. (logger.list_entries optimization using equals and docs update #1848)
• Ease construction of Sink and Metric instances using only name, assuming other properties will be fetched via reload(). (Add support for serialized/transactional read in 'Client.get{,_multi}'. #1861)

@tseaver also I made a release draft for 0.16.0 just fyi.

@tseaver, when I rerun

$ git log 0.15.0..HEAD | grep 'Merge pull request ' |  awk -F ' ' '{print $4}' | sort

I don't see the new PRs in there...#1813, #1860, #1844...possibly others?

Any ideas?

Have you merged your local master with upstream/master?

I rebased it.

Do they show up for you?

Also, "merge w/ squash commits" doesn't create a merge commit findable by that command line. I manually ran git log 0.15.0..HEAD and looked at the commits to uncover #1844, for instance.

Ah that's it! I did use the github squash merge and I didn't add "Merge pull request" to the commit message.

I left out #1860 since you mentioned it's not user facing really.

@tseaver I think once we get the GRPCIO 0.14.0 issues on appveyor and the docs generation working we can cut this release right?

I think once we get the GRPCIO 0.14.0 issues on appveyor and the docs generation working we can cut this release right?

SGTM

Is grpcio 0.14.0 expected to Just Work (TM) on Windows? Given my last comments on #1863, I'd say we could go ahead with our release even though Appveyor is broken.

@tseaver, is there any fallout we could be heading towards by releasing?

It looks like my credentials helper function errors if it doesn't have permissions. I can just catch that in an except so it fails more peacefully.

https://ci.appveyor.com/project/daspecster/gcloud-python/build/1.0.1.master/job/433qv2dtg3uq4a4t#L513

I'd say we can go ahead and release, unless @jgeewax thinks that the grpico-on-Windows bit from #1815 is a blocker.

@tseaver we could merge in #1868 to fix some of the appveyor issues but not all obviously.

Sounds good. The remaining failures will then be blocked on a fix for grpc/grpc#6939.

Ok, sounds like a plan. Is there anything we can do to help resolve that?

@daspecster I just updated the checklist to pull in #1870 and the need to fix #1869.

@daspecster #1874 reverts pubsub defaults to the safe JSON-over-HTTP. AFAIK, it would be the last change needed before merging here.

We should probably note this in the release notes.

@daspecster I just updated the release note above for pubsub.

Good to go then right?

Yup!