| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
lgtm |
Sorry, something went wrong.
|
I am 👎 on the quick merge without a more in-depth investigation. I'm pretty sure this snuck in because our [pep8] settings aren't getting picked up after the switch to pycodestyle |
Sorry, something went wrong.
|
Sorry, I can revert. I looked and the offending line is https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/scripts/verify_included_modules.py#L119 Which is called from https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L153 actually and not the pep8 stuff AFAICT. |
Sorry, something went wrong.
|
Also sorry if you think it was too hasty but it did fix my PR. |
Sorry, something went wrong.
|
Also, by [pep8] settings you're referring to in the tox.ini (https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L144). Switching it to [pycodestyle] produces a bunch of errors like it's not picking it up for some reason. Might be a pycodestyle bug? I tried it before when I did the pep8->pycodestyle conversion and it broke then too. |
Sorry, something went wrong.
|
That is a failure in pylint, not pycodestyle: it is trying to check docs/conf.pyscripts/verify_included_modules.py. We could just exclude that file from pylint. |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
First seen #1946 (comment)
Not sure how this got through?