FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Sphinx as a dependency for linting by daspecster · Pull Request #2019 · googleapis/google-cloud-python · GitHub

Add Sphinx as a dependency for linting - #2019

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-lint-sphinx-dep
Jul 22, 2016
Merged

Add Sphinx as a dependency for linting#2019
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-lint-sphinx-dep

Conversation

Copy link
Copy Markdown
Contributor

First seen #1946 (comment)

Not sure how this got through?

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2016

waprin commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

lgtm

daspecster merged commit 04a2543 into googleapis:master Jul 22, 2016

dhermes commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

I am 👎 on the quick merge without a more in-depth investigation. I'm pretty sure this snuck in because our [pep8] settings aren't getting picked up after the switch to pycodestyle

daspecster commented Jul 22, 2016
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry, I can revert. I looked and the offending line is https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/scripts/verify_included_modules.py#L119

Which is called from https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L153 actually and not the pep8 stuff AFAICT.

waprin commented Jul 22, 2016

Copy link
Copy Markdown
Contributor

Also sorry if you think it was too hasty but it did fix my PR.

Copy link
Copy Markdown
Contributor Author

Also, by [pep8] settings you're referring to in the tox.ini (https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L144). Switching it to [pycodestyle] produces a bunch of errors like it's not picking it up for some reason.

Might be a pycodestyle bug? I tried it before when I did the pep8->pycodestyle conversion and it broke then too.

Copy link
Copy Markdown
Contributor Author

We can talk more here #2020

tseaver commented Jul 23, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

That is a failure in pylint, not pycodestyle: it is trying to check docs/conf.pyscripts/verify_included_modules.py. We could just exclude that file from pylint.

daspecster added a commit to daspecster/google-cloud-python that referenced this pull request Jul 23, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver thanks! Here we go #2021.

This was referenced Aug 3, 2016
daspecster deleted the fix-lint-sphinx-dep branch January 24, 2017 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL