FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change [pep8]-> [pycodestyle] in tox.ini by daspecster · Pull Request #2020 · googleapis/google-cloud-python · GitHub

Change [pep8]-> [pycodestyle] in tox.ini - #2020

Merged
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:tox-pycodestyle-config
Nov 4, 2016
Merged

Change [pep8]-> [pycodestyle] in tox.ini#2020
daspecster merged 3 commits into
googleapis:masterfrom
daspecster:tox-pycodestyle-config

Conversation

daspecster commented Jul 22, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Here's an example of what I was talking about in #2019 (comment).

pycodestyle reference: PyCQA/pycodestyle#550

daspecster added hygiene do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 22, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2016

Copy link
Copy Markdown
Contributor Author

I deleted the cache on travis for this PR too. No dice.

daspecster force-pushed the tox-pycodestyle-config branch from 75aae3b to 3fa7391 Compare July 23, 2016 16:28

dhermes commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

Is there documentation to support either syntax?

daspecster commented Jul 25, 2016
edited
Loading

Copy link
Copy Markdown
Contributor Author

From: http://pep8.readthedocs.io/en/latest/intro.html#configuration

Travis says it's pulling in pycodestyle=2.0.0 AFAICT.

dhermes commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

👍

Copy link
Copy Markdown
Contributor Author

pycodestyle still hasn't cut a release yet.

dhermes commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Refresh me, what is the release we're waiting for

Copy link
Copy Markdown
Contributor Author

Supporting [pycodestyle] in the config instead of [pep8].

On Wed, Aug 17, 2016 at 2:30 PM, Danny Hermes notifications@github.com
wrote:

Refresh me, what is the release we're waiting for


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALvyKLNTlabyMiswmQILZLb-6OAr05Kks5qg1MqgaJpZM4JTL4U
.

Tom Schultz

dhermes commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Ah. Shucks.

Copy link
Copy Markdown
Contributor Author

Should get a release for this soon! PyCQA/pycodestyle#574 (comment)

daspecster force-pushed the tox-pycodestyle-config branch from 3fa7391 to d7783a6 Compare September 21, 2016 19:36

tseaver commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

Ugh, THAT NO WORK!

Copy link
Copy Markdown
Contributor Author

@tseaver, Yeah not until they cut the release. They updated on their master branch a while ago but that change hasn't been pushed to pypi.

When they cut the release I'll start travis and it should just go green.

Copy link
Copy Markdown
Contributor Author

daspecster force-pushed the tox-pycodestyle-config branch from d7783a6 to 2f31ddc Compare November 4, 2016 16:09
daspecster force-pushed the tox-pycodestyle-config branch from 2f31ddc to fb5886f Compare November 4, 2016 16:12

dhermes commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

@dhermes b8d6ed6

dhermes commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

LGTM pending Travis

dhermes commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

Actually @daspecster it looks like the new version of pycodestyle picked up something it didn't before:

scripts/generate_json_docs.py:656:1: E305 expected 2 blank lines after class or function definition, found 1

Can you add an extra empty line before the if __name__ == '__main__' in that file?

dhermes commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

@daspecster LGTM to merge on Travis green. Also, is the don't merge label still relevant?

daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2016

Copy link
Copy Markdown
Contributor Author

Ok cool. Nope, forgot it was there.

daspecster merged commit fe4ef3c into googleapis:master Nov 4, 2016
daspecster deleted the tox-pycodestyle-config branch November 4, 2016 19:59
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…nfig

Change [pep8]-> [pycodestyle] in tox.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL