| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I deleted the cache on travis for this PR too. No dice. |
Sorry, something went wrong.
|
Is there documentation to support either syntax? |
Sorry, something went wrong.
|
From: http://pep8.readthedocs.io/en/latest/intro.html#configuration Travis says it's pulling in pycodestyle=2.0.0 AFAICT. |
Sorry, something went wrong.
|
👍 |
Sorry, something went wrong.
|
pycodestyle still hasn't cut a release yet. |
Sorry, something went wrong.
|
Refresh me, what is the release we're waiting for |
Sorry, something went wrong.
|
Supporting [pycodestyle] in the config instead of [pep8]. On Wed, Aug 17, 2016 at 2:30 PM, Danny Hermes notifications@github.com
Tom Schultz |
Sorry, something went wrong.
|
Ah. Shucks. |
Sorry, something went wrong.
|
Should get a release for this soon! PyCQA/pycodestyle#574 (comment) |
Sorry, something went wrong.
|
Ugh, THAT NO WORK! |
Sorry, something went wrong.
|
@tseaver, Yeah not until they cut the release. They updated on their master branch a while ago but that change hasn't been pushed to pypi. When they cut the release I'll start travis and it should just go green. |
Sorry, something went wrong.
|
Pycodestyle 2.1.0! |
Sorry, something went wrong.
|
@daspecster You need a version lower bound: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/75e46139695747ddd1bbbc8cd3841bb6897331c8/tox.ini#L214 |
Sorry, something went wrong.
Sorry, something went wrong.
|
LGTM pending Travis |
Sorry, something went wrong.
|
Actually @daspecster it looks like the new version of pycodestyle picked up something it didn't before: scripts/generate_json_docs.py:656:1: E305 expected 2 blank lines after class or function definition, found 1 Can you add an extra empty line before the if __name__ == '__main__' in that file? |
Sorry, something went wrong.
|
@daspecster LGTM to merge on Travis green. Also, is the don't merge label still relevant? |
Sorry, something went wrong.
|
Ok cool. Nope, forgot it was there. |
Sorry, something went wrong.
…nfig Change [pep8]-> [pycodestyle] in tox.ini
| Back | FazBrowse Home | New Git URL |
Here's an example of what I was talking about in #2019 (comment).
pycodestyle reference: PyCQA/pycodestyle#550