Slightly more explicit coverage for partition-related methods. - #2060
Merged
tseaver merged 3 commits intoAug 9, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
gcloud/bigquery/table.py
Outdated
| """ | ||
| if not (isinstance(value, six.string_types) | ||
| and value.upper() == "DAY") and value is not None: | ||
| if value not in ['DAY', None]: |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
New changes LGTM. I wonder why types.NoneType is missing in Py3. Feel free to merge after fixing that attribute error. Squash if you can. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Reduces lines in 'test_table.py' to appease pylint's arbitrary ceiling.
Copy link
Copy Markdown
Contributor
Author
|
I've rebased to master to get the tests fixed (after merging #2065). I will merge when Travis passes. |
Sorry, something went wrong.
Merged
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
* feat: Add ai_generate_bool to the bigframes.bigquery package * fix stuffs * Fix format * fix doc format * fix format * fix code * expose ai module and rename the function * add ai module to doc * fix test * fix test * Update bigframes/bigquery/_operations/ai.py Co-authored-by: Tim Sweña (Swast) <swast@google.com> --------- Co-authored-by: Tim Sweña (Swast) <swast@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #2058.