| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@dhermes qq: did we resolve the namespace/import issue? Will users be able to do; from google.cloud import storage
storage_client = storage.Client()? |
Sorry, something went wrong.
|
Other than the services in #2258 (logging and pubsub) everything is a normal package (not a namespace package) |
Sorry, something went wrong.
|
Can I be a jerk and block the release on that issue? I would prefer not to have to update sample code twice. |
Sorry, something went wrong.
|
@bjwatson Thoughts on timing? @jonparrott We are just in a state of flux until a release is cut. |
Sorry, something went wrong.
|
@dhermes how bad is the state of flux? is it better to push this out quickly or wait for #2258 to be resolved? Are they any other issues that would make upgrading more trivial than just updating imports? (Apologies for the slew of questions, I just want to make sure I understand the full picture) |
Sorry, something went wrong.
|
@dhermes also, do we have a changelog? |
Sorry, something went wrong.
|
I have yet to make the changelog. I'm a bit weary of doing it, it'll be big. Also some people may have started doing squash merges so my typical script won't see those PRs? |
Sorry, something went wrong.
|
@dhermes @jonparrott I would like to resolve the following first if possible:
I can be talked out of any of these if there are urgent overriding needs to get this release out. |
Sorry, something went wrong.
|
@bjwatson Do you have a timeframe on this? e.g. why hasn't the LGTM'd PR been merged? |
Sorry, something went wrong.
|
Sorry, something went wrong.
|
@bjwatson gax-python 0.13.0 has been published, although until we refresh codegen, the gax-google-... packages will still be restricted to 0.12.x. |
Sorry, something went wrong.
Sorry, something went wrong.
|
It'd be nice to have it in today, but I trust you're going as quick as you can. |
Sorry, something went wrong.
|
@dhermes I am. Regarding #2258, we can reduce risk and maybe get it done sooner by just focusing on the GAX namespace. The other part of the problem is fixing the gRPC namespace, mainly to be more consistent, but also to avoid conflicts for the ML libraries (the gRPC packages currently use google.cloud.{api} as a namespace for language, vision, and speech). We can hand-fix the ML gRPC packages ASAP, and then fix the other gRPC packages a little later. |
Sorry, something went wrong.
|
That SGTM. |
Sorry, something went wrong.
|
This would be great to get a 0.19.0 onto PyPy PyPI since the Datastore v1beta2 API is being deprecated on 9/30 https://cloud.google.com/datastore/release-notes
The previous 0.18.1 release had v1beta2. |
Sorry, something went wrong.
|
@overset Thanks for the heads up. FWIW, we haven't supported v1beta2 for a very long time.
Check out the release history for relevant releases near those dates |
Sorry, something went wrong.
|
@dhermes My previous comment was flat-out wrong and thanks for confirming 0.18.1 having upgdaded to Datastore v1beta3 via 64c28fd. We haven't seen a turn-down notice for v1beta3 but it is marked as deprecated. (Thanks for the s/PyPy/PyPI/ on the previous comment as well) |
Sorry, something went wrong.
|
Sure thing. Not sure when v1beta3 will be turned off. |
Sorry, something went wrong.
|
Time to make release notes. Yay for 130+ PRs! $ git log -1 --pretty=%H
6fb2d73ff6350590aa061bcd902422828340f337
$ git log 0.18.1..HEAD | grep 'Merge pull request ' | awk -F ' ' '{print $4}' | sort
yields #2035 |
Sorry, something went wrong.
This is the first release after the rename. Closes googleapis#2264.
Sorry, something went wrong.
|
I've tweaked the entries all into imperative mode. |
Sorry, something went wrong.
|
I updated vision to be more verbose so it's easier to reference later if needed. |
Sorry, something went wrong.
|
Content moved to #2336. |
Sorry, something went wrong.
|
@tseaver @daspecster Are we good to merge here? (Don't know why Travis is being fast on "push" builds to master but not "pr" builds.) |
Sorry, something went wrong.
|
Green! |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
Pushed the tag and added the notes: https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/0.19.0 (may need #2347 update) Push to PyPI should come from: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161121136 |
Sorry, something went wrong.
|
I updated the release notes to include the changes from #2347. |
Sorry, something went wrong.
Co-authored-by: ohmayr <omairn@google.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
* feat: add additional query stats This PR adds support for incremental query stats.
Replaced `sge.Anonymous` with `sge.func` for `ML.DISTANCE` calls to improve code clarity and consistency. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
| Back | FazBrowse Home | New Git URL |
This is the first release after the rename.
Also updated the account that does deployment from Silvio's to one shared by google-cloud. We'll likely need to ditch the deploy section and write a more customized script using twine once we deploy versions for each sub-package.
Closes #2264.