FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix monitoring documentation TOC. by daspecster · Pull Request #2247 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fix monitoring documentation TOC. - #2247

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-monitoring-toc
Sep 6, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Fix monitoring documentation TOC.#2247
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-monitoring-toc

Conversation

daspecster commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

Partial resolution for #2246.

The table of contents references were wrong.

daspecster added docs api: monitoring Issues related to the Cloud Monitoring API. labels Sep 6, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016
dhermes reviewed Sep 6, 2016
View reviewed changes
Comment thread docs/json/json/master/toc.json
{
"title": "Time Series Query",
"type": "gcloud/monitoring/index/query"
"type": "gcloud/monitoring/query/query"

This comment was marked as spam.

Sign in to view

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

@daspecster Let's once and for all write a script for generating this JSON. Hand-crafted JSON is just a bad idea. If we want custom edits, we'll write them in Python and make the script toss them into the autogenerated dictionary.

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

LGTM

daspecster commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes yeah, I've started doing this in a branch for another issue. I'll just go full tilt on this for the TOC. I should have a PR for it today.

daspecster merged commit 89eed0e into googleapis:master Sep 6, 2016
daspecster deleted the fix-monitoring-toc branch September 6, 2016 15:58

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

for another issue

It should be a standalone anyhow

daspecster commented Sep 6, 2016

Copy link
Copy Markdown
Contributor Author

Yeah, I was thinking of just making the toc a python dict? How does that sound for the first PR?

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

It doesn't amount to any actual change.

dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(python): update dependencies in .kokoro/docker/docs (#2247)
93bbaa2 
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
chore: Migrate fillna_op operator to SQLGlot (#2247)
d98e6a9 
Fixes b/447388852  🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

tseaver

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL