FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Vision logo detection by daspecster · Pull Request #2235 · googleapis/google-cloud-python · GitHub

Vision logo detection - #2235

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-logo-detection
Sep 10, 2016
Merged

Vision logo detection#2235
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:vision-logo-detection

Conversation

daspecster commented Sep 1, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

Based off #2224.

This adds EntityAnnotation, which is used by LOGO_DETECTION, LANDMARK_DETECTION, LABEL_DETECTION and TEXT_DETECTION.

Small PRs for the other three detection types will follow.

✅ I'll rebase this after #2224 gets merged in.

daspecster added the api: vision Issues related to the Cloud Vision API. label Sep 1, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2016
daspecster force-pushed the vision-logo-detection branch 2 times, most recently from 5b20369 to 81cb07c Compare September 1, 2016 18:05
daspecster force-pushed the vision-logo-detection branch 3 times, most recently from 7773a38 to c404c65 Compare September 9, 2016 17:32
daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

OK! @tseaver, I think this one is ready to go.

Comment thread google/cloud/vision/entity.py Outdated


class EntityAnnotation(object):
"""Representation of an entity returned from the Vision API."""

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor Author

Awesome thanks!

Copy link
Copy Markdown
Contributor Author

vercies -> vertices...

daspecster force-pushed the vision-logo-detection branch from c49c675 to 028be63 Compare September 9, 2016 20:46
daspecster force-pushed the vision-logo-detection branch from 028be63 to 67ba8e5 Compare September 10, 2016 00:26
daspecster merged commit f834020 into googleapis:master Sep 10, 2016
dhermes mentioned this pull request Sep 19, 2016
daspecster deleted the vision-logo-detection branch January 24, 2017 15:17
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: ohmayr <omairn@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
* Revert "fix: Correct connection normalization in blob system tests (#2222)"

This reverts commit a0e1e50e47c758bdceb54d04180ed36b35cf2e35.

* fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL