Vision image properties - #2320
Merged
daspecster merged 1 commit intoSep 15, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
daspecster
force-pushed
the
vision-image-properties
branch
from
a08bd4e to
c741476
Compare
September 15, 2016 02:38
daspecster
force-pushed
the
vision-image-properties
branch
2 times, most recently
from
71f4e4b to
e99b0e2
Compare
September 15, 2016 17:52
Copy link
Copy Markdown
Contributor
Author
|
@tseaver, I cleaned this up so it should be ready to checkout as well. |
Sorry, something went wrong.
daspecster
force-pushed
the
vision-image-properties
branch
from
e99b0e2 to
acc96bc
Compare
September 15, 2016 19:33
tseaver
reviewed
Sep 15, 2016
Comment thread
google/cloud/vision/color.py
Outdated
|
|
||
| @property | ||
| def red(self): | ||
| """Red color. |
This comment was marked as spam.
Comment thread
google/cloud/vision/color.py
| return self._red | ||
|
|
||
| @property | ||
| def green(self): |
This comment was marked as spam.
Comment thread
google/cloud/vision/color.py
| """ | ||
| return self._green | ||
|
|
||
| @property |
This comment was marked as spam.
Comment thread
google/cloud/vision/color.py
Outdated
|
|
||
| :type red: int | ||
| :param red: The amount of red in the color as a value in the interval | ||
| [0, 1]. |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/vision/color.py
| :param color: RGB components of the color. | ||
|
|
||
| :type score: float | ||
| :param score: Image-specific score for this color. Value in range [0, 1]. |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/vision/_fixtures.py
Outdated
| } | ||
| } | ||
| ] | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver, updated everything except the score docstring. That value is copied from their docs, but I can't seem to find a better explanation of it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
daspecster
force-pushed
the
vision-image-properties
branch
from
5fdb9da to
5e0da90
Compare
September 15, 2016 21:23
Merged
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based from #2319
Adds the image properties detection API for Vision.
This adds a fairly large ImagePropertiesAnnotation with several classes to absorb the color data in the response.
✅ Also after #2319 is merged I will clean up the weird commit history.