FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make handwritten JSON documents more uniform by dhermes · Pull Request #2171 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Make handwritten JSON documents more uniform - #2171

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-toc-json
Aug 23, 2016
ConversationCommits (3)ChecksFiles changed
Merged

Make handwritten JSON documents more uniform#2171
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:update-toc-json

Conversation

dhermes commented Aug 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Also

  • removing no longer needed toc-all.json
  • removing a section of toc.json in exceptions that didn't belong

Used the following script to update the content:

import json

files = [
    'docs/json/json/master/index.json',
    'docs/json/json/master/toc.json',
    'docs/json/manifest.json',
]

for filename in files:
    with open(filename, 'rb') as file_obj:
        content = json.load(file_obj)
    with open(filename, 'wb') as file_obj:
        json.dump(content, file_obj, indent=2, sort_keys=True,
                  separators=(',', ': '))  # Added separators later
        file_obj.write('\n')  # Added later

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
tseaver mentioned this pull request Aug 23, 2016
Merged

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster This will also break #2167, so I'll hold off on merging until you get it in 😉

Ping me though so I don't forget?

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Ok yeah, just waiting on travis again... ⏳

dhermes commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

Just rebased after #2167. Note that I added a newline to the end of each JSON file and also used custom json separators since by default a trailing space is used after the comma separator.

daspecster commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

LGTM.

dhermes merged commit 94c2743 into googleapis:master Aug 23, 2016
dhermes deleted the update-toc-json branch August 23, 2016 22:37
dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
feat: add ability to set autodetect_schema query param in update_table (
d462e2d 
#2171)

* Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

* fixup! Add ability to set autodetect_schema query_param

---------

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
chore: Add cleanup step for old UDFs in anonymous dataset (#2171)
476cac6 
* chore: Add cleanup step for old UDFs in anonymous dataset

* fix

* fix

* fix with some test code

* fix

* no retry

* fix retry

* disable doctest

* testing - increase timeout

* revert timout

* add warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL