Add retry for flaky 'topic.exists()' check. - #2214
Merged
tseaver merged 1 commit intoAug 29, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, might as well give it a try? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Isn't that handled in the #2215 PR though? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@daspecster #2214 is about the test_fetch_delete_subscription_w_deleted_topic failure: this PR is supposed to fix the test_list_subscriptions testcase. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Oh sorry, my browser started at the bottom line that you linked so I didn't even notice it. Silly chrome. |
Sorry, something went wrong.
Merged
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
* refactor: rename _apply_unary_ops to _apply_ops_to_sql * fix lint * fix mypy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #2111.