FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop the ultra-flaky test for orphaned subscriptions. by tseaver · Pull Request #2215 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Drop the ultra-flaky test for orphaned subscriptions. - #2215

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2080-pubsub-drop-flaky-orphan-test
Sep 2, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Drop the ultra-flaky test for orphaned subscriptions.#2215
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:2080-pubsub-drop-flaky-orphan-test

Conversation

tseaver commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

See:
#2080 (comment)

Closes #2080.

tseaver added api: pubsub Issues related to the Pub/Sub API. flaky labels Aug 28, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2016

daspecster commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

In #2080 (comment), you mentioned there are other tests that cover this case?

Otherwise LGTM. I agree we need to get the build green with as few logical gaps in test coverage as possible.

I wonder if we should have some kind of secondary set of system tests? It might be nice to track these kinds of issues for the upstream guys?

tseaver commented Aug 29, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster Another option would be to mark the test with @unittest.expectedFailure.

daspecster mentioned this pull request Aug 29, 2016
Merged

dhermes commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

See my comment on #2080. Let's hold off on merging this until we can get @tmatsuo to weigh in (or until a fixed time interval passes not hearing from him)

tseaver commented Aug 29, 2016

Copy link
Copy Markdown
Contributor Author

@dhermes WDYT of leaving it in place, but decorating it with @unittest.expected_failure? The back-end folks could use to to investigate, and meanwhile we would be green.

dhermes commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

Seems mostly OK. But an issue needs to be filed to follow up and fix it.

tseaver commented Aug 29, 2016

Copy link
Copy Markdown
Contributor Author

#2080 would stay open if we followed that route: ideally, we would assign it to @tmatsuo.

dhermes commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

OK

Mark ultra-flaky 'orphan subscrpition' test as an expected failure.
27eec9d 
Allows our tests to go green while the back-end investigates.

Also, drop the ultra-flaky 'self.assertFalse(topic.exists())' in
'test_list_subscriptions'.  It is redundant (names are unique), and dropping
it lets the test pass normally.

Toward #2080, #2111.

tseaver commented Aug 29, 2016

Copy link
Copy Markdown
Contributor Author

I just backed out the "delete the test" change and marked it with unittest.expectedFailure.

I also dropped the self.assertFalse(topic.exists()) (see #2111).

dhermes reviewed Aug 30, 2016
View reviewed changes
Comment thread system_tests/pubsub.py
def test_list_subscriptions(self):
TOPIC_NAME = 'list-sub' + unique_resource_id('-')
topic = Config.CLIENT.topic(TOPIC_NAME)
self.assertFalse(retry_unavailable(topic.exists)())

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Go ahead and merge

tseaver merged commit efe359a into googleapis:master Sep 2, 2016
tseaver deleted the 2080-pubsub-drop-flaky-orphan-test branch September 2, 2016 12:50
tseaver mentioned this pull request Sep 6, 2016
Closed
dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Sep 22, 2023
update streaming samples [(#2215)](GoogleCloudPlatform/python-docs-sa…
b686c70 
…mples#2215)
parthea added a commit that referenced this pull request Nov 24, 2025
feat: Add support for Python 3.13 (#2215)
866025a
parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(deps): update dependency google-api-core to v2.25.1 (#2215)
2e440bd
parthea pushed a commit that referenced this pull request Apr 1, 2026
feat: Polars engine supports std, var (#2215)
78870d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL