FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Switching from nosetests to py.test. by dhermes · Pull Request #2241 · googleapis/google-cloud-python · GitHub

Switching from nosetests to py.test. - #2241

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:use-pytest
Sep 3, 2016
Merged

Switching from nosetests to py.test.#2241
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:use-pytest

Conversation

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor Author

Comment thread setup.cfg
@@ -1,2 +0,0 @@
[nosetests]
exclude-dir = system_tests

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes force-pushed the use-pytest branch 3 times, most recently from 26626a2 to 19df78b Compare September 2, 2016 21:04
Comment thread tox.ini Outdated
commands =
{[testing]covercmd} --cover-min-percentage=100
{[testing]covercmd}
coverage report --show-missing --fail-under=100

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

In the process, fixing some PATH issues in "gcloud._helpers"
(path separator was explicitly provided, rather than using
"os.join"). Also the the associated tests were refactored
with more mocks so that they depend less on the OS.

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor Author

The continuous-integration/travis-ci/push check came up because I pushed theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project. (I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.

Copy link
Copy Markdown
Contributor

Lgtm

On Fri, Sep 2, 2016, 4:49 PM Danny Hermes notifications@github.com wrote:

The continuous-integration/travis-ci/push check came up because I pushed
theGoogleCloudPlatform/gcloud-python:use-pytest branch to this project.
(I did it so that the AppVeyor tests would spawn, mentioned above.)

That job didn't fail, I just canceled it, since it would be repetetive to
run both PUSH/PR for the same exact code.

This should be ready to merge if I can get an LGTM.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#2241 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUczhDUyiQmLqvqj2h4ZD2C7wdYa8bks5qmLXugaJpZM4Jz_YD
.

dhermes merged commit d586990 into googleapis:master Sep 3, 2016
dhermes deleted the use-pytest branch September 3, 2016 00:18
dhermes mentioned this pull request Sep 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL