| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@dhermes, @daspecster I'm tempted to kill off the Travis for the PR and merge immediately: the system tests pass with this change on my box, and tox -e lint is happy. Since the only point of it is to try to fix post-PR builds, I'd like to know whether it works. :) |
Sorry, something went wrong.
|
The resource ID has per-second granularity on Travis. You probably want to go lower by a factor of 100. Add an optional argument to multiply seconds in time.time() before casting to an int? |
Sorry, something went wrong.
|
@tseaver I urge you to resist the temptation. Travis won't run your job for hours so it's not worth subverting the review process |
Sorry, something went wrong.
|
I just read the definition of "subvert". A very dramatic word |
Sorry, something went wrong.
We're already mangling in the TRAVIS_BUILD_ID into the unique_resource_id return value on Travis: are you worried we will be running two jobs with the same ID? The theory here is that reusing a topic ID within one run is the source of the flakiness we are seeing in #2163 and #2192.
That means it will be double that number of hours before we know whether it works. |
Sorry, something went wrong.
|
Sorry I didn't realize your prefixes were unique, so it's moot. LGTM to merge (no need to wait on Travis if you've run all the tox environmentsvthst Travis will) |
Sorry, something went wrong.
|
*environments that (typing on phone, sorry) |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
* The message is a commit message, not a message to a user from an AI agent. Therefore, it should be output as is. Output: Remove Kokoro presubmit for unit, docs, and coverage. This commit removes the Kokoro presubmit configuration that runs `unit_noextras`, `unit`, `cover`, `docs`, and `docfx` nox sessions. These checks are already performed by GitHub Actions, making the Kokoro configuration redundant. The change involves removing the `NOX_SESSION` environment variable definition from `.kokoro/presubmit/presubmit.cfg`. * Update presubmit.cfg * Delete .kokoro/presubmit/presubmit.cfg --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
The hypothesis is that we are seeing flakiness due to rapid creation / deletion cycles on topics with the shared name.
Towards #2163, #2192.