FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding new Travis key. by dhermes · Pull Request #2292 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Adding new Travis key. - #2292

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-new-travis-key
Sep 9, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Adding new Travis key.#2292
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-new-travis-key

Conversation

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

PR #2288 broke the Travis build since the key stored (from 2014) didn't have the project ID as a value.

Also adding better instructing about the encrypted file.

Adding new Travis key.
4dfcc40 
PR googleapis#2288 broke the Travis build since the key stored (from 2014)
didn't have the project ID as a value.
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
dhermes mentioned this pull request Sep 9, 2016
Merged

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

I've also deleted the old and no longer used file encryption env. vars:

  • encrypted_a1b222e8c14d_key
  • encrypted_a1b222e8c14d_iv
  • encrypted_d4f2fba7a94f_key
  • encrypted_d4f2fba7a94f_iv

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Merging now to stop the permanent state of b0rken-ness. @tseaver and @daspecster please LMK if the "emergency" merge was problematic.

dhermes merged commit 49b3f1b into googleapis:master Sep 9, 2016
dhermes deleted the add-new-travis-key branch September 9, 2016 23:06

dhermes commented Sep 9, 2016

Copy link
Copy Markdown
Contributor Author

Was ready to say "Yay we're green!" but then:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/158880190

It's just #2080.

tseaver commented Sep 10, 2016

Copy link
Copy Markdown
Contributor

We could merge #2248 to make that one go away. ;)

This was referenced Sep 19, 2016
Merged
Merged
dhermes mentioned this pull request Oct 13, 2016
Merged
parthea pushed a commit that referenced this pull request Apr 1, 2026
refactor: switch RowNumber to 0-based indexing in sqlglot compiler (#…
25fd63b 
…2292)

This change aims to fix the tests failing in #2248 because of a 1-based
indexing error.

Fixes internal issue 417774347 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

tseaver

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL