If you put it in after_success it won't fail the build if there's a problem

@dhermes switched them back around. If I understand correctly though, even if the unittests fail, the docs will still get deployed. I don't know if that's the best case.

I don't know if that's the best case.

It's not. Are you deploying on PRs or just merges?

You'll have to apply the **kwargs fix from #2071

Yup, thanks!

I assume / hope the Yup wasn't for "Are you deploying on PRs or just merges?"

Apparently it is! I'm fixing that right now.

Oy

How does tox -e docs deploy to RTD? Is that just from the READTHEDOCS envar?

Update: nm I see the docs-rtd now.

It doesn't, https://readthedocs.org/projects/gcloud-python/ looks for commits to master and triggers a build.

The relevant file was scripts/update_docs.sh before you implemented the new docs env

A while ago, I made a separate script for the JSON docs, update_json_docs.sh. Travis is calling that now instead of tox -e json-docs directly.

Looking at https://github.com/GoogleCloudPlatform/gcloud-python/commits/master/.travis.yml it looks like tox already does this (#2016)

I guess I had more coffee in me back then.

It doesn't look like update_json_docs.sh checks if the docs build during a PR

That should run it every time, or were there some cases that you didn't want the docs to build? Also, should I have it build the RTD docs with tox -e docs?

I added that line as well.

tox -e docs has been changed by you (previously) to update_json_docs.sh, which now calls tox -e docs, thus creating an infinite recursion.

tox -e docs-rtd makes sure the docs actually build with Sphinx (which is the concern)

I didn't change tox -e docs, I added tox -e json-docs.

[testenv:docs]
https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L67

[testenv:json-docs]
https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L79

So I think it should be ok?

Except for my refactor now failing.

generate_json_docs.py: error: argument --tag: expected one argument

@dhermes updated! Looks like it worked.
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/153329212#L687

@daspecster This LGTM except for the tiny nit about using ${...}. Please squash and rename the PR to actually state what is happening

You can merge once you've fixed the nit and Travis goes green, no need to check with me