Normalize handling 403 for rate limits on 'dataset.create()'. - #2089
Merged
tseaver merged 3 commits intoAug 11, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
system_tests/bigquery.py
|
|
||
| # We need to wait to stay within the rate limits. | ||
| # The alternative outcome is a 403 Forbidden response from upstream. | ||
| # See: https://cloud.google.com/bigquery/quota-policy |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
A 429 ("Too many requests") would be way more appropriate than a 403
("Forbidden"), but there is nothing we can do about it here.
Addresses:
#2089 (comment)
Copy link
Copy Markdown
Contributor
We could deal with backend changes if / when tests fail. You can make it a bit less brittle via: 'rate limit' in error.message.lower() |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
In 10e4f51, I figured out that we capture the JSON error structure, which means we can use the documented rateLimitExceeded reason code, rather than sniffing at the message text. |
Sorry, something went wrong.
Exclude Forbidden exceptions which do not have 'rateLimitExceed' as the reason for one of their errors. Addresses: #2089 (comment).
Copy link
Copy Markdown
Contributor
|
Nice find! LGTM |
Sorry, something went wrong.
Merged
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
* fix: Transformers with non-standard column names through errors * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2075.