FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove old docsite app files so it doesn't overwrite on deploy by daspecster · Pull Request #2178 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Remove old docsite app files so it doesn't overwrite on deploy - #2178

Merged
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:remove-old-doc-site-files
Aug 24, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Remove old docsite app files so it doesn't overwrite on deploy#2178
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:remove-old-doc-site-files

Conversation

daspecster commented Aug 24, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

We're accepting docsite updates from gcloud-common now.
Anytime there is an update for the site committed to gcloud-common, their deploy-docs.sh file is run and updates the listed repos.

These files were being copied and overwriting the latest app files that were getting pushed by gcloud-common.

daspecster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. docs labels Aug 24, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2016

daspecster commented Aug 24, 2016

Copy link
Copy Markdown
Contributor Author

@callmehiphop can we force run deploy-docs.sh after this is merged to get the latest again from gcloud-common/site?

callmehiphop commented Aug 24, 2016

Copy link
Copy Markdown

Not sure, would restarting an older Travis job do the trick?

daspecster commented Aug 24, 2016

Copy link
Copy Markdown
Contributor Author

That's what I was going to do, but I thought I'd ask just to make sure.

dhermes commented Aug 24, 2016

Copy link
Copy Markdown
Contributor
  1. LGTM
  2. Why not just run the script locally?
  3. Can any of the other files go? e.g. the JSON files

daspecster commented Aug 24, 2016

Copy link
Copy Markdown
Contributor Author
  1. 🎉
  2. Good idea!
  3. I'm updating to remove extra html files. I think the rest is required?

@callmehiphop can you confirm that all we need is home.html in the json dir?

callmehiphop commented Aug 24, 2016

Copy link
Copy Markdown

@daspecster Yep!

daspecster merged commit cf59650 into googleapis:master Aug 24, 2016

daspecster commented Aug 24, 2016

Copy link
Copy Markdown
Contributor Author

Looks like it all worked! The top nav is working and the side nav collapsed appropriately.

dhermes mentioned this pull request Sep 19, 2016
Merged
daspecster deleted the remove-old-doc-site-files branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(deps): update dependency db-dtypes to v1.4.3 (#2178)
9e300e2 
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
chore: create DF._to_pandas_batches() for better type checking of P…
e82fd10 
…andasBatches` (#2178)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL