Implementing analyze sentiment method and helpers in language - #2189
Merged
dhermes merged 3 commits intoAug 26, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
gcloud/language/sentiment.py
|
|
||
| :type polarity: float | ||
| :param polarity: Polarity of the sentiment in the ``[-1.0, 1.0]`` range. | ||
| Larger numbers represent more positive sentiments. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
c70c471 looks fine, except for the (API-induced) confustion between polarity and magnitude. We may not be able to fix the conceptual issue, but maybe the docs have some words about the ideas? e8b1b0f is fine. 6c4b6ef looks fine: the last assertion looks like it could be either too broad (to avoid flaky failures). |
Sorry, something went wrong.
dhermes
force-pushed
the
language-impl-5
branch
from
6c4b6ef to
127e8ae
Compare
August 25, 2016 04:17
Copy link
Copy Markdown
Contributor
|
LGTM once the docstring for sentiment includes a link to the concept docs. |
Sorry, something went wrong.
dhermes
force-pushed
the
language-impl-5
branch
from
127e8ae to
e1c5c96
Compare
August 26, 2016 19:57
Merged
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
…-around time (#2189) Update to the CI/CD pipeline via github workflow to help cut turn-around time. * added github workflow * changed the number of pytest-xdist workers from "auto" to "8" (based on local tests and discussion with Tim, choosing auto sometimes takes longer to run than choosing a smaller number. I suspect this is partly because for small or short tests the overhead needed to setup a worker exceeds the time savings of having extra workers). * modified numerous tests to explicitly include a project path to avoid an attempt to find the project by making an external call via the pydata-google-auth workflow (which opens an input and waits for response from the user that never comes).
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2187 as diffbase.