FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update index.html back to sphinx version. by daspecster · Pull Request #2269 · googleapis/google-cloud-python · GitHub

Update index.html back to sphinx version. - #2269

Merged
daspecster merged 4 commits into
googleapis:gh-pagesfrom
daspecster:updates-from-rename-2
Sep 8, 2016
Merged

Update index.html back to sphinx version.#2269
daspecster merged 4 commits into
googleapis:gh-pagesfrom
daspecster:updates-from-rename-2

Conversation

Copy link
Copy Markdown
Contributor

Update navigation and glcoud references.

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 8, 2016
daspecster force-pushed the updates-from-rename-2 branch from 6e3c4c3 to 56c299f Compare September 8, 2016 16:41

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 8, 2016

dhermes commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

Can you give a preview of the new homepage?

daspecster commented Sep 8, 2016
edited
Loading

Copy link
Copy Markdown
Contributor Author

Site: http://daspecster.github.io/google-cloud-python
Sphinx theme: http://daspecster.github.io/google-cloud-python/latest/

I just noticed that when you click "Read the docs" the dropdown for switching languages has the wrong links in it.

Copy link
Copy Markdown
Contributor Author

@dhermes, how does this look?

dhermes commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

LGTM, maybe squash commits?

ASIDE: Could you explain what happened to home.html / how much of it remains / what did it do eventually?

daspecster force-pushed the updates-from-rename-2 branch from 35b0ab2 to 511b343 Compare September 8, 2016 22:01

Copy link
Copy Markdown
Contributor Author

Squshed!

home.html is for the gcloud-common doc site. It's location and name are defined in the manifest.json.

The src and json folders are all that's left from the gcloud-common site.
I can remove those as well if you want but I'll need to get our repo removed from 'deploy-docs.sh`.

dhermes commented Sep 8, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

@daspecster I'd say you should proceed as follows (in order):

  1. Remove our repo from deploy-docs.sh
  2. Remove the src and json folders (and anything else that's dead) from gh-pages and do it in this PR

daspecster commented Sep 8, 2016
edited
Loading

Copy link
Copy Markdown
Contributor Author

dhermes commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

@daspecster It seems that versions.html should stick around for old docsets:
https://googlecloudplatform.github.io/google-cloud-python/versions.html

Copy link
Copy Markdown
Contributor Author

@dhermes I added versions.html back and updated the links.
I'll squash before merging if this looks good?

dhermes commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

LGTM. No need to squash, in that it could be painful.

Regarding the updating of versions.html, it's kind of the same idea as old docs versions. If they break, they break and that's OK.

daspecster merged commit 5f6459b into googleapis:gh-pages Sep 8, 2016
dhermes mentioned this pull request Sep 19, 2016
daspecster deleted the updates-from-rename-2 branch January 24, 2017 15:19
parthea pushed a commit that referenced this pull request Mar 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL