| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Sorry, something went wrong.
|
CLAs look good, thanks! |
Sorry, something went wrong.
|
Can you give a preview of the new homepage? |
Sorry, something went wrong.
|
Site: http://daspecster.github.io/google-cloud-python I just noticed that when you click "Read the docs" the dropdown for switching languages has the wrong links in it. |
Sorry, something went wrong.
|
@dhermes, how does this look? |
Sorry, something went wrong.
|
LGTM, maybe squash commits? ASIDE: Could you explain what happened to home.html / how much of it remains / what did it do eventually? |
Sorry, something went wrong.
|
Squshed! home.html is for the gcloud-common doc site. It's location and name are defined in the manifest.json. The src and json folders are all that's left from the gcloud-common site. |
Sorry, something went wrong.
|
@daspecster I'd say you should proceed as follows (in order):
|
Sorry, something went wrong.
Sorry, something went wrong.
|
@daspecster It seems that versions.html should stick around for old docsets: |
Sorry, something went wrong.
|
@dhermes I added versions.html back and updated the links. |
Sorry, something went wrong.
|
LGTM. No need to squash, in that it could be painful. Regarding the updating of versions.html, it's kind of the same idea as old docs versions. If they break, they break and that's OK. |
Sorry, something went wrong.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Fixes internal issue 445774480 🦕
| Back | FazBrowse Home | New Git URL |
Update navigation and glcoud references.