Move storage code into a subpackage - #2416
Merged
dhermes merged 2 commits intoSep 26, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
32 tasks
theacodes
approved these changes
Sep 25, 2016
theacodes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a few tiny things.
Sorry, something went wrong.
Comment thread
storage/README.rst
Outdated
| bucket = client.get_bucket('bucket-id-here') | ||
| # Then do other things... | ||
| blob = bucket.get_blob('remote/path/to/file.txt') | ||
| print blob.download_as_string() |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
tox.ini
| --cov-append \ | ||
| --cov-config {toxinidir}/.coveragerc \ | ||
| core/unit_tests | ||
| py.test --quiet \ |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
force-pushed
the
make-storage-subpackage
branch
from
dd9c52e to
9af414d
Compare
September 26, 2016 16:30
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver Yes essentially all will conflict, but luckily I can just re-run the script (that is why I ran it).
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
OK, LGTM |
Sorry, something went wrong.
Done via: $ mkdir -p storage/google/cloud $ cp google/__init__.py storage/google/__init__.py $ git add storage/google/__init__.py $ cp google/cloud/__init__.py storage/google/cloud/__init__.py $ git add storage/google/cloud/__init__.py $ git mv google/cloud/storage storage/google/cloud/storage $ git mv unit_tests/storage storage/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-storage as a dependency to the umbrella
package
- Adding the storage subdirectory into the list of packages
for verifying the docs
- Incorporating the storage subdirectory into the umbrella
coverage report
- Adding the storage only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the storage
tox config
dhermes
force-pushed
the
make-storage-subpackage
branch
from
9af414d to
b01ffb4
Compare
September 26, 2016 19:37
Copy link
Copy Markdown
Contributor
Author
|
Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful. |
Sorry, something went wrong.
This was referenced Sep 26, 2016
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
export PROJECT_DIR="${HOME}/google-cloud-python" export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357" cd ${PROJECT_DIR} git worktree add -b make-storage-subpackage ../hotfix official/master python make_commits.py \ --git-root "${PROJECT_DIR}/../hotfix" \ --package storage \ --package-name "Google Cloud Storage" \ --readme "${READMES_DIR}/storage/README.rst"