Move logging code into a subpackage - #2420
Merged
dhermes merged 6 commits intoSep 26, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
32 tasks
theacodes
approved these changes
Sep 25, 2016
Comment thread
logging/README.rst
Outdated
|
|
||
| entries, token = logger.list_entries() | ||
| for entry in entries: | ||
| print entry.payload |
This comment was marked as spam.
This comment was marked as spam.
dhermes
force-pushed
the
make-logging-subpackage
branch
from
eee2def to
ab4b5be
Compare
September 26, 2016 16:32
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Done via: $ mkdir -p pubsub/google/cloud $ cp google/__init__.py pubsub/google/__init__.py $ git add pubsub/google/__init__.py $ cp google/cloud/__init__.py pubsub/google/cloud/__init__.py $ git add pubsub/google/cloud/__init__.py $ git mv google/cloud/pubsub pubsub/google/cloud/pubsub $ git mv unit_tests/pubsub pubsub/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-pubsub as a dependency to the umbrella
package
- Adding the pubsub subdirectory into the list of packages
for verifying the docs
- Incorporating the pubsub subdirectory into the umbrella
coverage report
- Adding the pubsub only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the pubsub
tox config
Done via: $ mkdir -p logging/google/cloud $ cp google/__init__.py logging/google/__init__.py $ git add logging/google/__init__.py $ cp google/cloud/__init__.py logging/google/cloud/__init__.py $ git add logging/google/cloud/__init__.py $ git mv google/cloud/logging logging/google/cloud/logging $ git mv unit_tests/logging logging/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-logging as a dependency to the umbrella
package
- Adding the logging subdirectory into the list of packages
for verifying the docs
- Incorporating the logging subdirectory into the umbrella
coverage report
- Adding the logging only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the logging
tox config
In the process removing GRPC_PACKAGES entirely.
dhermes
force-pushed
the
make-logging-subpackage
branch
from
ab4b5be to
d4cc658
Compare
September 26, 2016 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2419 as diffbase.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
export PROJECT_DIR="${HOME}/google-cloud-python" export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357" cd ${PROJECT_DIR} git worktree add -b make-logging-subpackage ../hotfix origin/make-pubsub-subpackage python make_commits.py \ --git-root "${PROJECT_DIR}/../hotfix" \ --package logging \ --package-name "Stackdriver Logging" \ --readme "${READMES_DIR}/logging/README.rst" \ --extra-requires $' \'grpcio >= 1.0.0\',\n \'google-gax >= 0.14.1, < 0.15dev\',\n \'gapic-google-logging-v2 >= 0.9.0, < 0.10dev\',\n \'grpc-google-logging-v2 >= 0.9.0, < 0.10dev\',\n'NOTE: Since only pubsub and logging had to remove extra deps from GRPC_PACKAGES in setup.py, the 3rd commit is just written the old-fashioned way.