Move speech code into a subpackage - #2431
Closed
dhermes wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
32 tasks
theacodes
approved these changes
Sep 26, 2016
Done via: $ mkdir -p speech/google/cloud $ cp google/__init__.py speech/google/__init__.py $ git add speech/google/__init__.py $ cp google/cloud/__init__.py speech/google/cloud/__init__.py $ git add speech/google/cloud/__init__.py $ git mv google/cloud/speech speech/google/cloud/speech $ git mv unit_tests/speech speech/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-speech as a dependency to the umbrella
package
- Adding the speech subdirectory into the list of packages
for verifying the docs
- Incorporating the speech subdirectory into the umbrella
coverage report
- Adding the speech only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the speech
tox config
Done via: $ git grep -l 'unit_tests.speech._fixtures' | > xargs sed -i s/'unit_tests.speech._fixtures'/'unit_tests._fixtures'/g
This is because the implementation is not complete.
dhermes
force-pushed
the
make-speech-subpackage
branch
from
2a5022f to
9c00d52
Compare
September 27, 2016 00:11
Copy link
Copy Markdown
Contributor
Author
|
Rebased after #2432. Had a Green build but I can't merge this because after it's over, the google/ and unit_tests/ directories are empty, which makes the umbrella tox -e py${VERSION}$ tests fail. |
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
Skip all blob tests Fixes #<481790217> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
export PROJECT_DIR="${HOME}/google-cloud-python" export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357" cd ${PROJECT_DIR} git worktree add -b make-speech-subpackage ../hotfix official/master python make_commits.py \ --git-root "${PROJECT_DIR}/../hotfix" \ --package speech \ --package-name "Google Cloud Speech" \ --readme "${READMES_DIR}/speech/README.rst"Last two commits written by hand. Final commit takes it out of the umbrella package since the implementation isn't complete.
FYI @daspecster this will have implications on open PRs.