FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move translate code into a subpackage by dhermes · Pull Request #2432 · googleapis/google-cloud-python · GitHub

Move translate code into a subpackage - #2432

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:make-translate-subpackage
Sep 26, 2016
Merged

Move translate code into a subpackage#2432
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:make-translate-subpackage

Conversation

dhermes commented Sep 26, 2016
edited
Loading

Copy link
Copy Markdown
Contributor

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-translate-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package translate \
  --package-name "Google Translate" \
  --readme "${READMES_DIR}/translate/README.rst"

dhermes added packaging api: translation Issues related to the Cloud Translation API API. labels Sep 26, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2016
Done via:

$ mkdir -p translate/google/cloud
$ cp google/__init__.py translate/google/__init__.py
$ git add translate/google/__init__.py
$ cp google/cloud/__init__.py translate/google/cloud/__init__.py
$ git add translate/google/cloud/__init__.py
$ git mv google/cloud/translate translate/google/cloud/translate
$ git mv unit_tests/translate translate/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-translate as a dependency to the umbrella
  package
- Adding the translate subdirectory into the list of packages
  for verifying the docs
- Incorporating the translate subdirectory into the umbrella
  coverage report
- Adding the translate only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the translate
  tox config
dhermes force-pushed the make-translate-subpackage branch from 5143916 to f80cdfc Compare September 26, 2016 23:57

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

Rebased after #2433. Green build

dhermes merged commit 77899d4 into googleapis:master Sep 26, 2016
dhermes deleted the make-translate-subpackage branch September 26, 2016 23:58
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Apr 1, 2026
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL