Fix #171: rework query clone to avoid spurious copy of dataset by tseaver · Pull Request #254 · googleapis/google-cloud-python · GitHub

Fixes #171.

Coverage remained the same when pulling 137bfe2 on tseaver:171-rework_query_clone_deepcopy into 906700b on GoogleCloudPlatform:master.

Incorporate feedback from @dhermes.

Coverage remained the same when pulling 7eae97f on tseaver:171-rework_query_clone_deepcopy into 906700b on GoogleCloudPlatform:master.

LGTM

It appears a comment I made never posted. I was confirming that kind would be set on clone just as it was in the constructor. It appears it should since after being initialized, the kind from the constructor would live on the pb.

Your comment is correct: the 'kind' is carried on the 'pb.

Fix #171: rework query clone to avoid spurious copy of dataset

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: regenerate API index Source-Link: googleapis/googleapis@40a03de Source-Link: googleapis/googleapis-gen@6c17328 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmMxNzMyOGU5ZTFjMmI1OGU5NjAwNzIyZThmYzhjYmU4NDYwMGQ3ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

…1.0 (#254)

* chore: use gapic-generator-python 0.58.4 fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: googleapis/googleapis-gen@46df624 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 459095142 Source-Link: googleapis/googleapis@4f1be99 Source-Link: googleapis/googleapis-gen@ae686d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9 feat: add audience parameter PiperOrigin-RevId: 456827138 Source-Link: googleapis/googleapis@23f1a15 Source-Link: googleapis/googleapis-gen@4075a85 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9 fix(v4beta1): remove Application and Profile services and and related protos, enums, and messages PiperOrigin-RevId: 453241222 Source-Link: googleapis/googleapis@7837470 Source-Link: googleapis/googleapis-gen@ae2c052 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWUyYzA1Mjc0MzcwNjE2MWFjOTVhZGM1MDQ4YWQ1YTNkZThhNjU4NSJ9

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: store artifacts in placer Source-Link: googleapis/synthtool@cb96037 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd * revert * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: disable Python snippetgen for bigtable PiperOrigin-RevId: 431126635 Source-Link: googleapis/googleapis@dbfbfdb Source-Link: googleapis/googleapis-gen@4b4a4e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGI0YTRlN2ZlYzczYzYwOTEzZDhiMTA2MWYwYjI5YWZmYjFlMmE3MiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…271) * feat: use backoff module instead of flaky * Updates after PR review Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [2.6.0](https://www.github.com/googleapis/python-vision/compare/v2.5.0...v2.6.0) (2021-10-20) ### Features * add support for python 3.10 ([#253](https://www.github.com/googleapis/python-vision/issues/253)) ([7d5e27a](https://www.github.com/googleapis/python-vision/commit/7d5e27af26b13e1854c50f2ff7a7bdd7feea7b0a)) ### Documentation * **readme:** add pylint limitations ([#246](https://www.github.com/googleapis/python-vision/issues/246)) ([e4fb61f](https://www.github.com/googleapis/python-vision/commit/e4fb61f276f4540149884e8098fc4575f30ec9a6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…[autoapprove] (#254) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

chore: relocate owl bot post processor

Source-Link: googleapis/synthtool@993985f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@eaef28e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

* TST: Update Conda CI build to use nightly pandas packages. Remove unused git-based pip requirements file. * Restore non-nightly conda build.

Fix the unused import of api_core.operation and protobuf.empty_pb2 in generated unit tests

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-api-core/compare/v2.0.0-b1...v2.0.0) (2021-08-18) ### ⚠ BREAKING CHANGES * drop support for Python 2.7 / 3.5 ([#212](https://www.github.com/googleapis/python-api-core/issues/212)) ([a30f004](https://www.github.com/googleapis/python-api-core/commit/a30f004e74f709d46e905dd819c71f43354e9ac9)) ### Bug Fixes * bump grpcio version to use stable aio API ([#234](https://www.github.com/googleapis/python-api-core/issues/234)) ([bdbf889](https://www.github.com/googleapis/python-api-core/commit/bdbf889210b709d7c1945f2160bcba9161b4dd2e)) * strip trailing _ from field mask paths ([#228](https://www.github.com/googleapis/python-api-core/issues/228)) ([ff6ef1b](https://www.github.com/googleapis/python-api-core/commit/ff6ef1bd07fa68307b7c82c910416d770e7b3416)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: update docfx minimum Python version Source-Link: googleapis/synthtool@bc07fd4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:30470597773378105e239b59fce8eb27cc97375580d592699206d17d117143d0 * update docfx nox session to use python 3.10 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…254)

Source-Link: googleapis/synthtool@85c23b6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@3551acd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:230f7fe8a0d2ed81a519cfc15c6bb11c5b46b9fb449b8b1219b3771bcb520ad2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…p/templates/python_library/.kokoro (#254) Source-Link: googleapis/synthtool@e13b22b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7ff4aad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244

Fixes #250

…lters. (#269) Fixes #254. Co-authored-by: Andrew Gorcester <andrew.gorcester@gmail.com> Co-authored-by: Carlos de la Guardia <cguardia@yahoo.com>

* chore: update renovate and codeowner * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update owlbot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

tseaver added 2 commits October 17, 2014 10:47

Add assertion that query cursor is copied during '_clone'.

449b15d

Rework Query._clone to avoid spurious copy of dataset.

137bfe2

Fixes #171.

tseaver mentioned this pull request Oct 17, 2014

Fix #170: handle namespaces in queries #255

Merged

dhermes reviewed Oct 17, 2014
View reviewed changes

Comment thread gcloud/datastore/query.py

This comment was marked as spam.

Sign in to view

Unused import.

7eae97f

Incorporate feedback from @dhermes.

tseaver added a commit that referenced this pull request Oct 17, 2014

Merge pull request #254 from tseaver/171-rework_query_clone_deepcopy

83e8262

Fix #171: rework query clone to avoid spurious copy of dataset

tseaver merged commit 83e8262 into googleapis:master Oct 17, 2014

tseaver deleted the 171-rework_query_clone_deepcopy branch October 17, 2014 20:00

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.9.0 (#254 )

a2ee510

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.4.5 (#254 )

9af9432

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.7.1 (#254 )

cf62076

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-media-translation to v0.1…

50e551f

…1.0 (#254)

parthea added a commit that referenced this pull request Jun 4, 2023

chore: update doc links from googleapis.dev to cloud.google.com (#254 )

e21831c

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency google-cloud-iam to v2.10.0 (#254 )

2840c1c

parthea added a commit that referenced this pull request Oct 21, 2023

Fix: #254 by increasing timeout, use backoff module instead of flaky (#…

0692c9d

…271) * feat: use backoff module instead of flaky * Updates after PR review Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: relocate owl bot post processor (#254 )

67c53ae

chore: relocate owl bot post processor

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 1.10.2 (#254 )

3778538

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency google-cloud-trace to v1.7.1 (#254 )

68b6377

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update dependency google-cloud-bigquery to v2.23.1 (#254 )

63ecb3e

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update dependency google-cloud-bigquery to v2.23.1 (#254 )

6641d99

parthea pushed a commit that referenced this pull request Sep 18, 2025

TST: Update Conda CI build to use nightly pandas packages. (#254 )

c3a8954

* TST: Update Conda CI build to use nightly pandas packages. Remove unused git-based pip requirements file. * Restore non-nightly conda build.

parthea pushed a commit that referenced this pull request Nov 24, 2025

Fix for #169 : unused imports (#254 )

21d3c8f

Fix the unused import of api_core.operation and protobuf.empty_pb2 in generated unit tests

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 0.8.0 (#254 )

7c8148f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 1.0.0 (#254 )

6c5a435

parthea added a commit that referenced this pull request Nov 24, 2025

chore: add default_version and codeowner_team to .repo-metadata.json (#…

79376fc

…254)

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: use an insecure channel under emulation (#254 )

4557cb8

Fixes #250

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: record source locations (#254 )

bccd3f0

parthea pushed a commit that referenced this pull request Nov 25, 2025

feat: record source locations (#254 )

04ee650

parthea pushed a commit that referenced this pull request Mar 2, 2026

docs: update samples in documentation (#254 )

86cb20a

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(deps): update dependency protobuf to v3.20.3 (#254 )

d98742c

Fix #171: rework query clone to avoid spurious copy of dataset by tseaver · Pull Request #254 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #171: rework query clone to avoid spurious copy of dataset - #254

Fix #171: rework query clone to avoid spurious copy of dataset#254
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:171-rework_query_clone_deepcopy

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #171: rework query clone to avoid spurious copy of dataset by tseaver · Pull Request #254 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #171: rework query clone to avoid spurious copy of dataset - #254

Fix #171: rework query clone to avoid spurious copy of dataset#254tseaver merged 3 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:171-rework_query_clone_deepcopyCopy head branch name to clipboard

Conversation

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #171: rework query clone to avoid spurious copy of dataset#254
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:171-rework_query_clone_deepcopy