Resolving cyclic imports in storage package. by dhermes · Pull Request #269 · googleapis/google-cloud-python · GitHub

This is accomplished by moving the definitions of
BucketIterator and KeyIterator into their respective
modules (i.e. storage.bucket and storage.key).

This is not so big an issue because the parent class
iterator.Iterator does most of the work and the children
only require a small tweak.

Partially addresses #260 and is the first commit from #267

LGTM, pending Travis.

Coverage decreased (-0.02%) when pulling 211a3e6 on dhermes:fix-cyclic-imports-storage into 99e4d53 on GoogleCloudPlatform:master.

Hmm, coveralls has coverage dropping on one line. The '_Bucket' testing jig class is no longer used.

Looks like 'gcloud.storage.iterator.KeyDataIterator' should move to 'gcloud.storage.key' as well: Key is its only client.

Removed the unused _Bucket class.

I intentionally didn't move KeyDataIterator because

it was a non-trivial class (unlike the two moved)
it is actually an iterator and hence belongs in the iterator module (unless we decide to remove this module)

This is accomplished by moving the definitions of BucketIterator and KeyIterator into their respective modules (i.e. storage.bucket and storage.key). This is not so big an issue because the parent class iterator.Iterator does most of the work and the children only require a small tweak.

Coverage remained the same when pulling 8de933f on dhermes:fix-cyclic-imports-storage into 88b0ec7 on GoogleCloudPlatform:master.

LGTM.

Resolving cyclic imports in storage package.

When a message is moved now the object_id changes

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…269) Source-Link: https://togithub.com/googleapis/synthtool/commit/b4fe62efb5114b6738ad4b13d6f654f2bf4b7cc0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: add question_id field in ReviewDocumentOperationMetadata PiperOrigin-RevId: 424949086 Source-Link: googleapis/googleapis@087bceb Source-Link: googleapis/googleapis-gen@af34793 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWYzNDc5MzBiNjZkZjUwZDMwY2QwNzllMjgyNzc2ZDA4ZWI3ZjJhYSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

) Co-authored-by: nicain <nicain.seattle@gmail.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: update Java and Python dependencies PiperOrigin-RevId: 408420890 Source-Link: googleapis/googleapis@2921f9f Source-Link: googleapis/googleapis-gen@6598ca8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9

Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

ENH: Use tz-aware dtype for timestamp columns in all supported pandas versions Adds a table documenting this behavior to the "reading" how-to guides.

Source-Link: googleapis/synthtool@8d392a5 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a0c4463fcfd9893fc172a3b3db2b6ac0c7b94ec6ad458c7dcea12d9693615ac3 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Tres Seaver <tseaver@palladion.com>

Source-Link: googleapis/synthtool@d50980e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5a4c19d17e597b92d786e569be101e636c9c2817731f80a5adec56b2aa8fe070 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

* using client credentials with emulator * feat: using client credentials with emulator * Adding tests for client._emulator_channel

…lters. (#269) Fixes #254. Co-authored-by: Andrew Gorcester <andrew.gorcester@gmail.com> Co-authored-by: Carlos de la Guardia <cguardia@yahoo.com>

Instead, create a subpackage, google.cloud.pubsub and add an __init__.py file to it.

tseaver added hygiene api: storage Issues related to the Cloud Storage API. labels Oct 20, 2014

tseaver mentioned this pull request Oct 20, 2014

Disentangle import cycles #260

Closed

dhermes added 2 commits October 20, 2014 15:25

Removed unused _Bucket class from iterator test.

8de933f

dhermes force-pushed the fix-cyclic-imports-storage branch from d5aa597 to 8de933f Compare October 20, 2014 22:25

dhermes added a commit that referenced this pull request Oct 21, 2014

Merge pull request #269 from dhermes/fix-cyclic-imports-storage

fab0237

Resolving cyclic imports in storage package.

dhermes merged commit fab0237 into googleapis:master Oct 21, 2014

dhermes deleted the fix-cyclic-imports-storage branch October 21, 2014 03:23

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Fix googleapis#269

1f89580

When a message is moved now the object_id changes

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#269 )

ab4a65b

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#269 )

23f10ec

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#269 )

40abd4c

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#269 )

48ad3c9

parthea added a commit that referenced this pull request Jun 4, 2023

chore: prepare for the monorepo migration (#269 )

2b76ffc

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.11.1 (#269 )

3ac0b1a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 0.11.2 (#269 )

12a139d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.7.1 (#269 )

6025266

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-compute to v1.3.0 (#269 )

abf98a1

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: allow releases from previous major versions (#269 )

6c83a4e

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: make samples 3.6 check optional (#269 )

94aefee

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-texttospeech to v2.6.0 (#269

46b5012

) Co-authored-by: nicain <nicain.seattle@gmail.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-data to v0.13.2 (#269 )

62bec31

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update all dependencies (#269 )

23714ef

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#269 )

da6796b

parthea pushed a commit that referenced this pull request Sep 18, 2025

ENH: Use tz-aware dtype for timestamp columns (#269 )

8d7fadb

ENH: Use tz-aware dtype for timestamp columns in all supported pandas versions Adds a table documenting this behavior to the "reading" how-to guides.

parthea pushed a commit that referenced this pull request Nov 24, 2025

Allow passing in individual files to the conversion script (#269 )

96eba77

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat!: PKCE is enabled by default. (#269 )

608a3dd

parthea added a commit that referenced this pull request Nov 24, 2025

chore: remove obsolete dependency in setup.py (#269 )

2ab556f

Co-authored-by: Tres Seaver <tseaver@palladion.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 0.13.1-alpha (#269 )

103d6cd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: support using client credentials with emulator (#269 )

e03cff4

* using client credentials with emulator * feat: using client credentials with emulator * Adding tests for client._emulator_channel

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(revert): revert preventing normalization (#269 )

102ee60

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(revert): revert preventing normalization (#269 )

78e5218

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(revert): revert preventing normalization (#269 )

3e0cbf8

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(revert): revert preventing normalization (#269 )

0bd37e2

parthea pushed a commit that referenced this pull request Mar 2, 2026

fix: Don't open the google.cloud package by adding pubsub.py (#269 )

e2b9593

Instead, create a subpackage, google.cloud.pubsub and add an __init__.py file to it.

This was referenced Mar 27, 2026

feat(sqlalchemy-spanner): wire timeout execution option through to DBAPI Connection.timeout #16467

Open

feat(sqlalchemy-spanner): wire timeout execution option through to DBAPI Connection.timeout #16468

Open

Resolving cyclic imports in storage package. by dhermes · Pull Request #269 · googleapis/google-cloud-python · GitHub

Uh oh!

Resolving cyclic imports in storage package. - #269

Resolving cyclic imports in storage package.#269
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-cyclic-imports-storage

dhermes commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

dhermes commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Resolving cyclic imports in storage package. by dhermes · Pull Request #269 · googleapis/google-cloud-python · GitHub

Uh oh!

Resolving cyclic imports in storage package. - #269

Resolving cyclic imports in storage package.#269dhermes merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:fix-cyclic-imports-storagedhermes/google-cloud-python:fix-cyclic-imports-storageCopy head branch name to clipboard

Conversation

dhermes commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

dhermes commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

coveralls commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Resolving cyclic imports in storage package.#269
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-cyclic-imports-storage