FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DON'T MERGE: Fix cyclic imports by dhermes · Pull Request #267 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

DON'T MERGE: Fix cyclic imports - #267

Closed
dhermes wants to merge 2 commits into
googleapis:masterfrom
dhermes:fix-cyclic-imports
ConversationCommits (2)ChecksFiles changed
Closed

DON'T MERGE: Fix cyclic imports#267
dhermes wants to merge 2 commits into
googleapis:masterfrom
dhermes:fix-cyclic-imports

Conversation

dhermes commented Oct 20, 2014

Copy link
Copy Markdown
Contributor

@tseaver this is a first stab and I want to discuss / see what you think.

The imports are easy to resolve in the storage package but not so in the datastore package. See the commit messages for more details.

Resolving cyclic imports in storage package.
3148468 
This is accomplished by moving the definitions of
BucketIterator and KeyIterator into their respective
modules (i.e. storage.bucket and storage.key).

This is not so big an issue because the parent class
iterator.Iterator does most of the work and the children
only require a small tweak.
Temp commit with idea to clear up cyclic imports in datastore package.
0a72dc4 
This is intended for discussion but not to be committed. Some remarks:

- This surfaces the fact that the use of Dataset in
  datastore.key.Key.from_protobuf is not well-tested enough.
- The changes to _helpers are made to avoid explicitly referencing
  the Entity class. These changes end up in uglier code
  for a minimal gain.
- We could likely factor out the Dataset ID/connection concept from
  the full "dataset" concept. It seems a Dataset and its convenience
  methods are referenced a lot in the docs but not really tested
  much.
dhermes mentioned this pull request Oct 20, 2014
Closed

tseaver commented Oct 20, 2014

Copy link
Copy Markdown
Contributor

I see what you mean about the datastore side. I think we should break this PR up into three parts:

  • the storage bits, which look "normal" (3148468, minus the pylintrc changes).
  • some factoring of the datastore side (based on 0a72dc4, but something needs rearranging).
  • the pylintrc changes from 3148468 (enabling cycle detection).

tseaver commented Oct 20, 2014

Copy link
Copy Markdown
Contributor

One big problem is the 'Dataset.entity' and 'Dataset.query' methods. They create the biggest cycle, and they are API smells. E.g., instead of:

query = dataset.query(kind='Kind')

the user can as easily type:

query = Query('Kind', dataset)

Likewise for entities:

entity = dataset.entity('Kind')

could as easily be:

entity = Entity(dataset, 'Kind')

I will submit a separate PR removing those two methods and updating the docs.

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. hygiene labels Oct 20, 2014
dhermes mentioned this pull request Oct 20, 2014
Merged
dhermes closed this Oct 21, 2014
dhermes deleted the fix-cyclic-imports branch October 23, 2014 20:47
atulep pushed a commit that referenced this pull request Apr 6, 2023
build: use trampoline_v2 for python samples and allow custom dockerfi…
ca86884 
…le (#267)

Source-Link: googleapis/synthtool@a7ed11e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
build: use trampoline_v2 for python samples and allow custom dockerfi…
86c5426 
…le (#267)

Source-Link: googleapis/synthtool@a7ed11e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
build: use trampoline_v2 for python samples and allow custom dockerfi…
072e897 
…le (#267)

Source-Link: googleapis/synthtool@a7ed11e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore: Update gapic-generator-python to v1.8.2 (#267)
607ffc5 
* chore: Update gapic-generator-python to v1.8.2

PiperOrigin-RevId: 504289125

Source-Link: googleapis/googleapis@38a48a4

Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#267)
5ea60d1 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea added a commit that referenced this pull request Jun 4, 2023
chore(deps): update all dependencies (#267)
b61d88d 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(main): release 1.8.1 (#267)
1c0a3c4 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#267)
706096c 
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#267)
bfad929 
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this pull request Jun 4, 2023
feat: add api key support (#267)
df6d625 
* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python

PiperOrigin-RevId: 423842556

Source-Link: googleapis/googleapis@a616ca0

Source-Link: googleapis/googleapis-gen@29b938c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
build(deps): bump requests to 2.31.0 [autoapprove] (#267)
27db165 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(main): release 1.8.0 (#267)
9e9d582 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore: update doc links from googleapis.dev to cloud.google.com (#267)
8af27c3 
Updating the reference documentation website from googleapis.dev to cloud.google.com for the index pages. Also updating references in the README.
parthea added a commit that referenced this pull request Jun 4, 2023
fix: require python 3.7+ (#267)
bf2e637 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
ci(python): fix path to requirements.txt in release script (#267)
372710f 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#267)
9c6bab0 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(python): allow client documentation to be customized in README (#…
3cd800e 
…267)

Source-Link: googleapis/synthtool@95d9289
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
chore(python): update release.sh to use keystore (#267)
56f22ed 
Source-Link: googleapis/synthtool@69fda12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(main): release 1.9.1 (#267)
778c80e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
chore(deps): update dependency pytest to v7.1.0 (#267)
9353dd0
parthea pushed a commit that referenced this pull request Sep 22, 2023
chore: make samples 3.6 check optional (#267)
54b5e6b
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency google-cloud-bigquery to v2.24.1 (#267)
ef5135d
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(python): Enable size-label bot (#267)
458cd02 
Source-Link: googleapis/synthtool@06e8279
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(python): add nox session to sort python imports (#267)
a8cafcc 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(python): Noxfile recognizes that tests can live in a folder (#267)
7353a83 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
feat: add context manager support in client (#267)
41fc3a5 
- [ ] Regenerate this pull request now.

chore: fix docstring for first attribute of protos

committer: @busunkim96
PiperOrigin-RevId: 401271153

Source-Link: googleapis/googleapis@787f8c9

Source-Link: googleapis/googleapis-gen@81decff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore: run the generator (#267)
61d6ae6 
* feat: add Address Validation API

PiperOrigin-RevId: 473247330

Source-Link: googleapis/googleapis@7b2540a

Source-Link: googleapis/googleapis-gen@206063c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjA2MDYzY2RlNWRmMmY2MGY3MTI2MjlkOGU2NDZmMzliYmJkZDVhNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 0.13.2 (#267)
66fd86c 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore: release 2.5.1 (#267)
095e864 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.5.1](https://www.github.com/googleapis/python-automl/compare/v2.5.0...v2.5.1) (2021-10-20)


### Bug Fixes

* remove unnecessary double quotes in strings ([#262](https://www.github.com/googleapis/python-automl/issues/262)) ([fb73bd7](https://www.github.com/googleapis/python-automl/commit/fb73bd7d5ab024aaec3bb0d892c587082911970b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency google-auth to v2.6.5 (#267)
128d59e
parthea pushed a commit that referenced this pull request Oct 22, 2023
chore: rename rst files to avoid conflict with service names (#267)
98319f0 
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
build: use trampoline_v2 for python samples and allow custom dockerfi…
eecdacc 
…le (#267)

Source-Link: googleapis/synthtool@a7ed11e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
chore: use gapic generator python 1.4.1 (#267)
a48e2fd 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9
parthea added a commit that referenced this pull request Dec 20, 2024
chore: remove obsolete proto files (#267)
23e0f96 
* chore: remove pb2 file generation during post processing

* fix: remove obsolete proto files

---------

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
parthea added a commit that referenced this pull request Aug 21, 2025
chore(deps): update dependency google-cloud-bigquery to v2.24.0 (#267)
25c1b5e 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Sep 16, 2025
chore(deps): update dependency google-cloud-bigquery to v2.24.0 (#267)
6b42d3e 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
CLN: Update the authentication credentials. (#267)
cf29d57 
These auth credentials for the browser authentication flow belong to the
pandas-gbq-auth GCP project. The reason for the fresh project is that
this allows us to explicitly enable APIs needed for new functionality,
such as the BigQuery Storage API.
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: change the library from preview to stable (#267)
2ca7e08
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: setting 64bit fields from strings supported (#267)
6224d1d 
Due to limitations in certain browser/javascript combinations,
fields that are 64 bit integer types are converted to strings when
encoding a message to JSON or a dict.
Decoding from JSON handles this explicitly, but it makes converting
back from a dict an error.

This fix adds support for setting these 64 bit fields explicitly from
strings.

E.g.

class Squid(proto.Message):
      mass_kg = proto.Field(proto.INT64, number=1)

s = Squid(mass_kg=10)
s_dict = Squid.to_dict(s)
# Demonstrate the issue
assert type(s_dict["mass_kg"]) == str

# Demonstrate the round trip conversion is transparent
assert s == Squid(s_dict)
s.mass_kg = "20"              # Works as an implementation side effect
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: release 2.0.1 (#267)
f091c5f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(deps): update dependency immutables to v0.16 (#267)
d914bb7 
* chore(deps): update dependency immutables to v0.16

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 2.4.1 (#267)
036029e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(python): add nox session to sort python imports (#267)
5d16665 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
feat: support span inference (#267)
2c98943
parthea pushed a commit that referenced this pull request Nov 25, 2025
feat: support span inference (#267)
62606e9
parthea pushed a commit that referenced this pull request Nov 26, 2025
Release v1.5.0 (#267)
f857d41
parthea pushed a commit that referenced this pull request Mar 2, 2026
chore: re-generate GAPIC layer with changes from from googleapis (via…
6288c55 
… synth) (#267)

* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore: update gapic-generator-python to 0.40.11

PiperOrigin-RevId: 359562873

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Feb 25 10:52:32 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 07932bb995e7dc91b43620ea8402c6668c7d102c
Source-Link: googleapis/googleapis@07932bb

* feat: Added client libraries for Google Workspace Marketplace API

PiperOrigin-RevId: 359658993

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Feb 25 18:10:16 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: ee4bac5de3e4bfc4bbca87a6b256f1a58dcfadd0
Source-Link: googleapis/googleapis@ee4bac5

* fix: Update to PHP micro-generator beta02; fixes some bazel build issues.

PiperOrigin-RevId: 359844338

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Feb 26 14:51:50 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 9adc11e84218d5e234392e7fe81676e778895525
Source-Link: googleapis/googleapis@9adc11e
parthea pushed a commit that referenced this pull request Mar 2, 2026
fix: un-pin google-crc32c (#267)
4b659c5 
This reverts commit 9fa344f42a99db1af27b8ca126a2ea6b3c01d837.

Co-authored-by: Andrew Gorcester <gorcester@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency requests-toolbelt to v0.10.0 (#267)
a3b39c3
parthea pushed a commit that referenced this pull request Mar 9, 2026
fix: preserve existing blob hashes when 'X-Goog-Hash header' is not p…
654c2a6 
…resent (#267)

Co-authored-by: Tres Seaver <tseaver@palladion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL