@waprin I forgot, can you assign people and add labels to PRs?

I can't. Though my teammates could change that for me, up to you guys if you want us to.

@waprin I gave you one-off write access to this repo. We can refactor this as a Github team if there are other Stackdriver devs we should include (especially if you need access to multiple google-cloud-* repos).

FYI @jgeewax @daspecster @dhermes @tseaver @omaray @danoscarmike

LGTM, but I'll let @tseaver or @dhermes sign off.

This PR is pointless unless the package actually uses the depended upon package?

@dhermes the next incoming PR will actually use this client, but it's still not pointless, the idea is that we keep the pip install experience consistent whether it's handwritten or a GAPIC. You install google-cloud-* to get the clients, regardless of if the are hand-written, GAPICs, or a mix. So there will be a bunch of APIs that just have a GAPIC we just install the dependency here for. Or in cases like this, a GAPIC and then maybe some hand-written code on top. At least that's how it's been explained to me.

Yes, that's how it's been explained to me as well, but AFAIK the generated libraries are not in the "ready to go" state yet (e.g. no docs).

@dhermes We'll get on top of publishing GAPIC docs for all APIs in January. We also need to discuss how to integrate them with google-cloud-python docs as discussed in https://github.com/GoogleCloudPlatform/gcloud-common/issues/207.

@dhermes @bjwatson @steren this is not remotely ready for thorough review (missing tests, docs, lots of stye issues) but I wanted to throw up the commits to give the rough sketch of adding the GAPIC as a transport for the helper API, make sure it's all LGTM to you guys and then I'll clean up the PR to merge it.

This is basically what Steren and I had discussed a few weeks ago.

• Copies the basic GAX/non-GAX structure of the logging client
• Unlike the logging client, instead of falling back to an HTTP client, it falls back to the logging client itself, now in _logging
• Basic instrumentation/helper library API remains the same, code to build the error report payload is shared

If you all feel good about this I'll finish up the tests/docs/style issues.

Obviously not expecting any response on this until 2017, happy new year! 🎉 🎉 🎈 🎈

@dhermes @bjwatson @steren ping for the new year. again, just looking for an initial +1 to basic direction here before I finish tests/docs.

Thanks @waprin. Looks reasonable to me based on a superficial review.

@lukesneeringer Can you take a more detailed look? This should have a similar structure to the Logging code that you've looked at already.

Cool ty, will finish it up then.

The direction LGTM.

Would you mind also update the doc, so that I better understand how the end user will configure and use the module in its various variants?

In general, a parameter like use_gax is very cryptic to anybody who does not know what gax is (I guess most users).

Will this work also allow to call, for example, the list groupStat endpoint from the module?

@bjwatson @lukesneeringer cool ty, I wanted to ask, do we need the secure channel stuff? Is there a high level overview of that?

One other problem I've run into is that Error Reporting depends on gax 0.14 but logging (which Error Reporting uses as the fallback) depends on 0.15, and ssl_creds changed to ssl_credentials. Wonder if we can just update the error reporting gax dependency?

@steren will try to clarify the gRPC stuff.

Since we are adding the GAPIC to the module, all the autogenned VTK calls will be included as a dependency. Documentation of all those calls is still a TODO as noted above. For now this just adds the GAPIC library to this one and uses it for the handwritten helper functions.

@waprin I believe we'll need to regenerate the GAPIC code to work with GAX 0.15. Is that correct @geigerj?

The changes allow us to use @jonparrott's new google-auth library, rather than requiring the broken old oauth2client.

@bjwatson Yes, we should regenerate the GAPIC library to use GAX 0.15.0.

@dhermes this is ready for review