Fix __eq__ and __ne__. - #3765
Merged
lukesneeringer merged 5 commits intoAug 8, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
Aug 8, 2017
Comment thread
bigquery/google/cloud/bigquery/_helpers.py
| self.value == other.value) | ||
|
|
||
| def __ne__(self, other): | ||
| return not self == other |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
reviewed
Aug 8, 2017
Comment thread
bigquery/google/cloud/bigquery/schema.py
| return self._key() != other._key() | ||
| else: | ||
| return NotImplemented | ||
| return not self == other |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates __eq__ to do type-checking correctly on all classes (except mock classes defined in unit test modules):
def __eq__(self, other): if not isinstance(other, type(self)): return NotImplementedIt also updates __ne__ to be exactly:
def __ne__(self, other): return not self == otherFixes #3455.