Auto-generated trace library (GAPIC only) by liyanhui1228 · Pull Request #3512 · googleapis/google-cloud-python · GitHub

No description provided.

ISTM you want to move trace/docs/ to docs/trace/?

Also, please make PRs from branches in your own fork of this repo (rather then making branches directly in this repo).

UPDATE: I now see that #3513 is a PR against your new branch (trace-autogen). I'm not sure I grok the order you want these merges to occur in.

@dhermes Yeah the docs should live in docs/trace. Will move it later.

And sorry for forgetting to make PRs from my own fork... I remember you told me in last PR though. I spent quite a while separating the previous large PR to two PRs this afternoon because of some weird errors and then forgot that.

#3513 is based on the trace-autogen branch, which is the manual layer on top of the autogen layer. So I think the merging order should be merging the manual one to this autogen branch first then merge the autogen branch to master.

The trace team is working on adding v2 of the API, timeline hazy, but v1 is in reasonably heavy use and will presumably remain so. The two apis are quite similar, just some renaming and slightly restructuring. It seems reasonable to me to have autogen code for v1 now, add v2 later, and have the manual layer work for both. But @lukesneeringer will have to say for sure.

Also, my git (lack of skill) is entirely to blame for any problems with these two pull requests, although @liyanhui1228 was much too kind to say so :) We spent a while trying to resurrect the previous pull request from a deleted branch.

Please don't hesitate to reach out for git issues. I'm a bit of a git surgeon.

…

On Wed, Jun 21, 2017, 2:17 AM Douglas Greiman ***@***.***> wrote: Also, my git (lack of skill) is entirely to blame for any problems with these two pull requests, although @liyanhui1228 <https://github.com/liyanhui1228> was much too kind to say so :) We spent a while trying to resurrect the previous pull request from a deleted branch. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3512 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc6y5M7kYSa2rd7M4P99dSMFZ6A_Cks5sGN-ygaJpZM4N--OD> .

@lukesneeringer Are there any plan for updating the autogen code to use the v2 API? I have #3513 ongoing based on this PR, so if there are anything needed to be changed in the autogen code please let me know.

Hi @liyanhui1228,
How did you generate this code? I want to make sure I get proto docstrings added in, is why I ask. It should just entail re-generating with the newest Artman.

Happy to do it and update this PR; I just need to know what you based it off of.

@lukesneeringer Are there any plan for updating the autogen code to use the v2 API? I have #3513 ongoing based on this PR, so if there are anything needed to be changed in the autogen code please let me know.

This is based off of v1, yes? Most likely they can live side by side.

@lukesneeringer This is just the one you generated before, I wasn't able to reopen that closed PR so I open a new one for the autogen code. It would be great if you regenerate and update this PR, I just need to know if there is any change for calling the APIs as my manual code PR is based on this.

A couple minor changes. None of them are strict blockers if you are on a time crunch.

@liyanhui1228 @lukesneeringer This broke the docs build

@dhermes I'm looking at it right now.

Thanks!

Auto-generated trace library (GAPIC only)

91398bb

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2017

liyanhui1228 requested review from duggelz and theacodes June 20, 2017 01:39

liyanhui1228 requested a review from dhermes June 20, 2017 16:47

Move trace/docs to docs/trace

8b5557d

liyanhui1228 added the api: cloudtrace Issues related to the Cloud Trace API. label Jun 27, 2017

liyanhui1228 added 2 commits July 25, 2017 14:07

Implemented trace library based on the autogen, gax only (#3513 )

57160b2

Removed trace and trace_span which will be in opencensus repo

afcaa51

lukesneeringer suggested changes Jul 26, 2017

View reviewed changes

Fix conf.py

0ad0c58

lukesneeringer approved these changes Jul 26, 2017

View reviewed changes

lukesneeringer merged commit 86316d4 into master Jul 26, 2017

lukesneeringer deleted the trace-autogen branch July 26, 2017 20:51

dhermes mentioned this pull request Jul 26, 2017

Simplifying Client constructor's for Bigtable and Spanner. #3672

Merged

dhermes mentioned this pull request Jul 26, 2017

Prep langauge-0.26.0 release. #3680

Merged

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017

Auto-generated trace library (GAPIC only) (googleapis#3512 )

6ca1e5e

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Auto-generated trace library (GAPIC only) (googleapis#3512 )

f0c2fae

landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017

Auto-generated trace library (GAPIC only) (googleapis#3512 )

02d7f7d

busunkim96 mentioned this pull request Jul 30, 2020

feat!: migrate to microgenerator googleapis/python-trace#29

Merged

parthea pushed a commit that referenced this pull request Oct 22, 2023

Auto-generated trace library (GAPIC only) (#3512 )

ae11abf

+              # (source start file, target name, title, author,
+              #  dir menu entry, description, category)
+              texinfo_documents = [
+                  (master_doc, 'gapic-google-cloud-trace-v1',

+              master_doc = 'index'
+              # General information about the project.
+              project = u'gapic-google-cloud-trace-v1'

+                      # Finally, track the GAPIC package version.
+                      metrics_headers['gapic'] = pkg_resources.get_distribution(
+                          'google-cloud-trace', ).version

		@@ -0,0 +1,2 @@
		googleapis-common-protos>=1.5.2, <2.0dev

Auto-generated trace library (GAPIC only) by liyanhui1228 · Pull Request #3512 · googleapis/google-cloud-python · GitHub

Uh oh!

Auto-generated trace library (GAPIC only) - #3512

Auto-generated trace library (GAPIC only)#3512lukesneeringer merged 5 commits intomastergoogleapis/google-cloud-python:masterfrom trace-autogengoogleapis/google-cloud-python:trace-autogenCopy head branch name to clipboard

Conversation

liyanhui1228 commented Jun 20, 2017

Uh oh!

dhermes commented Jun 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liyanhui1228 commented Jun 20, 2017

Uh oh!

duggelz commented Jun 21, 2017

Uh oh!

duggelz commented Jun 21, 2017

Uh oh!

theacodes commented Jun 21, 2017 via email

Uh oh!

liyanhui1228 commented Jun 26, 2017

Uh oh!

lukesneeringer commented Jul 5, 2017

Uh oh!

lukesneeringer commented Jul 5, 2017

Uh oh!

liyanhui1228 commented Jul 5, 2017

Uh oh!

lukesneeringer left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jul 26, 2017

Uh oh!

liyanhui1228 commented Jul 26, 2017

Uh oh!

dhermes commented Jul 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Auto-generated trace library (GAPIC only)#3512
lukesneeringer merged 5 commits into
masterfrom
trace-autogen

dhermes commented Jun 20, 2017 •
edited
Loading