FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Prep langauge-0.26.0 release. by tseaver · Pull Request #3680 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Prep langauge-0.26.0 release. - #3680

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:language-release-0.26.0
Jul 27, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Prep langauge-0.26.0 release.#3680
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:language-release-0.26.0

Conversation

tseaver commented Jul 26, 2017

Copy link
Copy Markdown
Contributor 
$ git log language-0.25.0..HEAD language/ | grep "^commit"
commit a813160b0e3de635cfba6e5f46099debcd77a08e
commit 14e570a3f435f8904ed9fa52d545a35ba5868ad1
commit 3d9461b91963fcc6e6a864f6f0eacad3d92bbf2d
commit da3a7bbe8c7770540c2149fabfc6f74db89f7ce4
commit bc7b0fdb9fd99b2c86de9830a25cfaaa295b1c45
commit b9cb6d17236528ddce982c3e802af3221de80880
commit 39feb3e23d451963ca31b383d8b395afcf7ab817
commit 6ab3e0127a1edf8b1f9f1603f3c1342473563ea7

All except the last (PR #3679) are internal / housekeeping / testing. So, draft release notes:

google-cloud-language 0.26.0

  • Adding a (mostly) autogenerated surface side-by-side with the previously provided Client (NL GAPIC #3679)

tseaver added api: language Issues related to the Cloud Natural Language API API. packaging labels Jul 26, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2017
dhermes reviewed Jul 26, 2017
View reviewed changes
Comment thread language/setup.py
setup(
name='google-cloud-language',
version='0.25.0',
version='0.26.0',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer approved these changes Jul 26, 2017
View reviewed changes

lukesneeringer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved. It is fine to release this first (it is more urgent) and then do the metapackage.

lukesneeringer commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

Let me know if anything blocks this. (DPE is waiting on it to publish their work.)

tseaver commented Jul 26, 2017

Copy link
Copy Markdown
Contributor Author

@lukesneeringer the docs build is failing:

/var/code/gcp/docs/language/gapic/v1/api.rst:4: (WARNING/2) autodoc: failed to import module 'google.cloud.language_v1'; the following exception was raised:
Traceback (most recent call last):
  File "/var/code/gcp/.nox/docs/lib/python3.6/site-packages/sphinx/ext/autodoc.py", line 657, in import_object
    __import__(self.modname)
ModuleNotFoundError: No module named 'google.cloud.language_v1'

lukesneeringer commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

I think that is a chicken and egg problem, because docs installs the released packages. @dhermes, is that accurate?

dhermes commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

@lukesneeringer That is not accurate. nox -s docs and RTD both build from source

lukesneeringer commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

Bah, okay, I will look into it. I built them locally repeatedly.

dhermes commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

@lukesneeringer It was broken by #3512 and is being fixed by #3683

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

Ah. I can not wait until our packages do not pollute one another.

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

It turned out this was a chocobo and egg problem after all, but in a way that is easy to fix. The Noxfile had:

    session.install(
        'core/', 'bigquery/', 'bigtable/', 'datastore/', 'dns/', 'language/',
        'logging/', 'error_reporting/', 'monitoring/', 'pubsub/',
        'resource_manager/', 'runtimeconfig/', 'spanner/', 'speech/',
        'storage/', 'trace/', 'translate/', 'vision/',
    )
    session.install('-e', '.')

The second line plowed over the local installs in the first line.

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

Note: The last commit is a cherry-pick from #3688. There will be no translate changes in this PR once that hits master.

tseaver commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

The generated language_v1 package is not being installed during the docs build:

$ ll .nox/docs/lib/python3.6/site-packages/google/cloud/
total 212
drwxrwxr-x 26 tseaver tseaver  4096 Jul 27 09:29 ./
drwxrwxr-x 15 tseaver tseaver  4096 Jul 27 09:29 ../
drwxrwxr-x  4 tseaver tseaver  4096 Jul 27 09:29 bigquery/
drwxrwxr-x  4 tseaver tseaver  4096 Jul 27 09:29 bigtable/
-rw-rw-r--  1 tseaver tseaver  8726 Jul 26 15:45 client.py
-rw-rw-r--  1 tseaver tseaver  7605 Dec  3  2016 credentials.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 datastore/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 dns/
-rw-rw-r--  1 tseaver tseaver  1319 Dec  3  2016 environment_vars.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 error_reporting/
-rw-rw-r--  1 tseaver tseaver  6672 Jul 25 14:12 exceptions.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 future/
drwxrwxr-x 12 tseaver tseaver  4096 Jul 27 09:29 gapic/
-rw-rw-r--  1 tseaver tseaver 19641 Jul 25 14:12 _helpers.py
-rw-rw-r--  1 tseaver tseaver 11441 Jul 25 14:12 _http.py
-rw-rw-r--  1 tseaver tseaver  6879 Jul 25 14:12 iam.py
-rw-rw-r--  1 tseaver tseaver 15781 Jul 25 14:12 iterator.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 language/
drwxrwxr-x  4 tseaver tseaver  4096 Jul 27 09:29 logging/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 monitoring/
-rw-rw-r--  1 tseaver tseaver  9082 Jul 25 14:12 operation.py
drwxrwxr-x 10 tseaver tseaver  4096 Jul 27 09:29 proto/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 pubsub/
drwxrwxr-x  2 tseaver tseaver  4096 Jul 27 09:29 __pycache__/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 resource_manager/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 runtimeconfig/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 spanner/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 speech/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 speech_v1/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 storage/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 streaming/
-rw-rw-r--  1 tseaver tseaver  3435 Jul 25 14:12 _testing.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 translate/
-rw-rw-r--  1 tseaver tseaver   923 Jul 27 09:29 videointelligence.py
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 videointelligence_v1beta1/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 vision/
drwxrwxr-x  3 tseaver tseaver  4096 Jul 27 09:29 vision_v1/

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

@tseaver Are you sure? It builds correctly on CI now (once trace and translate are fixed).

tseaver commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

I would argue that the pip install --upgrade . is actually redundant (we're installing everything twice, once from released versions and once from the local checkout).

tseaver commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

@lukesneeringer I hadn't pulled your changes in. It is building cleanly now on my local machine.

How do you want to handle ordering this one and #3688?

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

I just merged #3688. I propose we merge master into this, push, (should re-run tests but otherwise just remove those changes from the "Files Changed" tab), then merge this.

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

I would argue that the pip install --upgrade . is actually redundant (we're installing everything twice, once from released versions and once from the local checkout).

It totally is, but the build fails without it (as you noted on #3688).
Is there a way in pip to do the google-cloud install without the deps? (I do not know of one.)

Regardless, we can do that separately later.

tseaver commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

Rebased, removing all the stuff from #3688. I will merge when green and tag.

tseaver merged commit 440b214 into googleapis:master Jul 27, 2017
tseaver deleted the language-release-0.26.0 branch July 27, 2017 15:43

tseaver commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

Automated PyPI push wins!

dhermes commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

Is it worth continuing pushing versions to google-cloud-natural-language?

lukesneeringer commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

Does PyPI (or warehouse) have any way to redirect a package? In a perfect world I would like to make it so pip install google-cloud-natural-language just forwards.

dhermes commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

AFAIK no, but I'll let @jonparrott have the final word on that

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dhermes dhermes left review comments
lukesneeringer lukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL