Storage: Track deleted labels; make Bucket.patch() send them. - #3737
Storage: Track deleted labels; make Bucket.patch() send them.#3737lukesneeringer merged 7 commits into
Conversation
Sorry, something went wrong.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate. |
Sorry, something went wrong.
|
Grumble grumble grumble @googlebot. |
Sorry, something went wrong.
|
#3715 merged, so you can rebase to appease googlebot. |
Sorry, something went wrong.
Turns out some properties (i.e., 'labels', see googleapis#3711) behave differently under 'patch semantics'[1], which makes 'update' useful. [1] https://cloud.google.com/storage/docs/json_api/v1/how-tos/performance#patch
|
Done, just need a review (and to fix CI). |
Sorry, something went wrong.
| ``client`` stored on the current object. | ||
| """ | ||
| answer = super(Bucket, self).update(client=client) | ||
| self._label_removals.clear() |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
| _, _, kwargs = client._connection.api_request.mock_calls[0] | ||
| self.assertEqual(len(kwargs['data']['labels']), 2) | ||
| self.assertEqual(kwargs['data']['labels']['color'], 'red') | ||
| self.assertEqual(kwargs['data']['labels']['flavor'], 'cherry') |
This comment was marked as spam.
This comment was marked as spam.
|
Thanks for catching that @tseaver. Updates made. |
Sorry, something went wrong.
| # If the values are reset, the changes must as well. | ||
| self._changes = set() | ||
| if hasattr(self, '_label_removals'): | ||
| self._label_removals.clear() |
This comment was marked as spam.
This comment was marked as spam.
|
@tseaver @jonparrott Can someone give this a final signoff so I can merge it? :-) |
Sorry, something went wrong.
Uses #3715 as a base.
This PR adds tracking for deleted labels on the Bucket object, and causes the appropriate data to be sent when Bucket.patch is called.
Fixes #3711.