FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump storage to 1.4.0 by lukesneeringer · Pull Request #3869 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Bump storage to 1.4.0 - #3869

Merged
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:storage-1.4.0
Aug 24, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Bump storage to 1.4.0#3869
lukesneeringer merged 2 commits into
googleapis:masterfrom
lukesneeringer:storage-1.4.0

Conversation

lukesneeringer commented Aug 24, 2017

Copy link
Copy Markdown
Contributor

Release notes:

lukesneeringer self-assigned this Aug 24, 2017
lukesneeringer requested a review from dhermes August 24, 2017 21:09
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2017
dhermes approved these changes Aug 24, 2017
View reviewed changes

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Worth noting: Your release note style is somewhat different than what I've used over the years. This is neither good nor bad, just worth noting. (You can design a "sentiment" if you please.)

lukesneeringer commented Aug 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Tacking to your style for now; can discuss at repo split but I think what you are doing is fine. (Eventually I may want to automate it.)

lukesneeringer merged commit ce9ca35 into googleapis:master Aug 24, 2017
parthea pushed a commit that referenced this pull request Mar 9, 2026
Bump storage to 1.4.0 (#3869)
3298675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
dhermes dhermes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lukesneeringer

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL